-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pantheon updates 2022-02-01 #157716
Merged
Merged
Pantheon updates 2022-02-01 #157716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: pantheon
The Pantheon desktop environment
8.has: module (update)
This PR changes an existing module in `nixos/`
labels
Feb 1, 2022
ofborg
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
labels
Feb 1, 2022
bobby285271
changed the title
nixos/pantheon: stop setting GTK_CSD=1
Pantheon updates 2021-02-01
Feb 2, 2022
ofborg
bot
added
the
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
label
Feb 2, 2022
github-actions
bot
added
8.has: changelog
8.has: documentation
This PR adds or changes documentation
labels
Feb 2, 2022
Simply because all other Pantheon packages have addressed these formatting.
This is mostly Pantheon version of e703bc0, we move the aliases outside of the scope.
This shouldn't appear in search.nixos.org.
ofborg
bot
added
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Feb 2, 2022
ofborg
bot
removed
the
2.status: merge conflict
This PR has merge conflicts with the target branch
label
Feb 2, 2022
Result of 2 packages blacklisted:
2 packages built:
|
@ofborg test pantheon I think I need to figure out why we disable plugins for elementary-photos at initial packaging... Tracked as https://github.com/NixOS/nixpkgs/projects/21#card-77112141 |
bobby285271
added
the
8.has: upstream changes reviewed
Reviewer checked the changelogs/commit logs associated with the release and did not find any issues.
label
Feb 3, 2022
github-actions
bot
removed
8.has: changelog
8.has: documentation
This PR adds or changes documentation
labels
Feb 3, 2022
I dropped 0b5e0222ba4f830cd31abf74f8fa1d44bd55d3de as I consider removing the module without a review is dangerous... Going to merge this, waiting for ofborg eval |
13 tasks
13 tasks
bobby285271
added
the
8.has: port to stable
A PR already has a backport to the stable release.
label
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: pantheon
The Pantheon desktop environment
8.has: clean-up
8.has: module (update)
This PR changes an existing module in `nixos/`
8.has: port to stable
A PR already has a backport to the stable release.
8.has: upstream changes reviewed
Reviewer checked the changelogs/commit logs associated with the release and did not find any issues.
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Pantheon 6.1 follow-ups (previous one at #156936)
GTK_CSD=1
has been dropped by upstream since elementary OS 6, see elementary/gala#244 and elementary/default-settings#103, I think issues mentioned in 399ff42 are no longer there. To test, build and run https://github.com/bobby285271/test-gtk-csd before and after the change.Also some minor cleanups and formats. Easier to review commit by commit.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes