Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/pantheon: add mutter to services.udev.packages #219004

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Mar 1, 2023

For ./lib/udev/rules.d/61-mutter.rules

Same as d1eeb64. This is forgotten in #130380.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

For ./lib/udev/rules.d/61-mutter.rules

Same as d1eeb64. This is forgotten in PR 130380.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 1, 2023
@bobby285271 bobby285271 mentioned this pull request Mar 1, 2023
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 1, 2023
@bobby285271
Copy link
Member Author

Built the pantheon test locally. I decided that it will be rude to ask ofborg to (re-)test the flaky test when webkitgtk needs to be rebuilt...

@bobby285271 bobby285271 merged commit 3374c1a into NixOS:master Mar 2, 2023
@bobby285271 bobby285271 deleted the fix/pantheon-add-mutter-udev branch March 2, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant