Skip to content

llvm: backport patch for musl 1.2.4#229442

Merged
alyssais merged 12 commits intoNixOS:stagingfrom
alyssais:llvm-musl-1.2.4
May 3, 2023
Merged

llvm: backport patch for musl 1.2.4#229442
alyssais merged 12 commits intoNixOS:stagingfrom
alyssais:llvm-musl-1.2.4

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented May 2, 2023 •
edited
Loading

Description of changes

See #229439.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@alyssais alyssais added the 6.topic: musl Running or building packages with musl libc label May 2, 2023
@alyssais alyssais changed the title Llvm musl 1.2.4 llvm: backport patch for upcoming musl release May 2, 2023
@alyssais alyssais mentioned this pull request May 2, 2023
Merged
47 tasks
@alyssais alyssais changed the title llvm: backport patch for upcoming musl release llvm: backport patch for musl 1.2.4 May 2, 2023
@alyssais alyssais force-pushed the llvm-musl-1.2.4 branch from 7f67f44 to cd9f932 Compare May 2, 2023 09:08
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label May 2, 2023
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 2, 2023
@ofborg ofborg bot added the 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. label May 2, 2023
rrbutani
rrbutani approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@rrbutani rrbutani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #228712.

Should this be #229439?

Regardless, looks good to me!

@rrbutani
Copy link
Contributor

rrbutani commented May 2, 2023 •
edited
Loading

(perhaps obvious but in case anyone else was wondering about LLVM 16 and #223282 like I was: llvm/llvm-project@5cd5543 has already been backported: llvm/llvm-project@a468d19)

@RaitoBezarius
Copy link
Member

RaitoBezarius commented May 2, 2023

Feel free to merge. :)

@alyssais alyssais merged commit ad10899 into NixOS:staging May 3, 2023
@alyssais alyssais deleted the llvm-musl-1.2.4 branch May 3, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaitoBezarius RaitoBezarius RaitoBezarius approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@lovek323 lovek323 Awaiting requested review from lovek323

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@primeos primeos Awaiting requested review from primeos

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@dtzWill dtzWill Awaiting requested review from dtzWill

+1 more reviewer

@rrbutani rrbutani rrbutani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: musl Running or building packages with musl libc 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alyssais @rrbutani @RaitoBezarius