Conversation
Janik-Haag
added
the
12.first-time contribution
Lurkki14
force-pushed
the
lurkki/omorfi
branch
2 times, most recently
from
a4c4d99 to
dca50e6
Compare
ofborg
bot
added
8.has: package (new)
|
Could you please split into separate commits (libvoiko, hfst, omorfi, etc)? |
ofborg
bot
added
the
11.by: package-maintainer
There was a problem hiding this comment.
Nit: a bit unusual order, more common is pname, version, src, nativeBuildInputs, buildInputs, meta.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2393 |
There was a problem hiding this comment.
This comment isn't helpful for other to pick this up
There was a problem hiding this comment.
Not sure I can see easily anywhere what the error is, since I don't have a Darwin machine
There was a problem hiding this comment.
So we can run a pythonImportsCheck?
Can/Should we run https://github.com/flammie/omorfi/tree/main/test ?
There was a problem hiding this comment.
Those tests are already runnable in the checkPhase of omorfi
There was a problem hiding this comment.
not to helpful for others to pick this up and fix it
There was a problem hiding this comment.
omorfi> checking python module: libhfst... no
omorfi> configure: error: failed to find required module libhfstLooks like it should be easy to fix. I'll try to investigate...
There was a problem hiding this comment.
| # Ofborg build error | |
| # fails to find libhfst on darwin |
There was a problem hiding this comment.
| python3Packages.wrapPython | |
| python3.pkgs.wrapPython |
There was a problem hiding this comment.
| python3Packages.hfst | |
| python3.pkgs.hfst |
There was a problem hiding this comment.
I've figured out how to fix tests on darwin:
| # Package builds but tests fail on Darwin | |
| doCheck = !stdenv.isDarwin; | |
| preCheck = lib.optionalString stdenv.isDarwin '' | |
| export DYLD_LIBRARY_PATH="${foma}/lib" | |
| ''; |
There was a problem hiding this comment.
| sourceRoot = "source/libvoikko"; | |
| sourceRoot = "${src.name}/libvoikko"; |
There was a problem hiding this comment.
| sourceRoot = "source/python"; | |
| sourceRoot = "${src.name}/python"; |
There was a problem hiding this comment.
| sourceRoot = "source/src/python"; | |
| sourceRoot = "${src.name}/src/python"; |
drupol
left a comment
drupol
left a comment
There was a problem hiding this comment.
Hi !
Thanks for your first contribution.
I added some feedback. Most of it is to use the finalAttrs pattern.
Feel free to let me know if you need some assistance.
Thanks!
There was a problem hiding this comment.
I think we should use the finalAttrs pattern here.
Since this is your first PR, let me share a couple of useful links regarding this:
- History: https://discourse.nixos.org/t/avoid-rec-expresions-in-nixpkgs/8293
- Documentation: https://nixos.org/manual/nixpkgs/unstable/#mkderivation-recursive-attributes
- Recent example of implementation: https://github.com/NixOS/nixpkgs/compare/17f96f7b978e61576cfe16136eb418f74fab9952..9e6ea843e473d34d4f379b8b0d8ef0425a06defe
There was a problem hiding this comment.
I think we should use the finalAttrs pattern here.
Since this is your first PR, let me share a couple of useful links regarding this:
- History: https://discourse.nixos.org/t/avoid-rec-expresions-in-nixpkgs/8293
- Documentation: https://nixos.org/manual/nixpkgs/unstable/#mkderivation-recursive-attributes
- Recent example of implementation: https://github.com/NixOS/nixpkgs/compare/17f96f7b978e61576cfe16136eb418f74fab9952..9e6ea843e473d34d4f379b8b0d8ef0425a06defe
6 participants
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)