Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.dm-haiku: fix build #249140

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

natsukium
Copy link
Member

@natsukium natsukium commented Aug 14, 2023

Description of changes

I applied two patches to fix the build.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium natsukium added the 0.kind: build failure A package fails to build label Aug 14, 2023
@natsukium natsukium marked this pull request as ready for review August 14, 2023 14:55
@natsukium
Copy link
Member Author

Result of nixpkgs-review pr 249140 run on x86_64-linux 1

12 packages marked as broken and skipped:
  • python310Packages.distrax
  • python310Packages.distrax.dist
  • python310Packages.rlax
  • python310Packages.rlax.dist
  • python311Packages.distrax
  • python311Packages.distrax.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.rlax
  • python311Packages.rlax.dist
  • python311Packages.treex
  • python311Packages.treex.dist
7 packages failed to build:
  • python310Packages.elegy
  • python310Packages.elegy.dist
  • python310Packages.treex
  • python310Packages.treex.dist
  • python311Packages.dm-haiku
  • python311Packages.dm-haiku.dist
  • python311Packages.dm-haiku.testsout
3 packages built:
  • python310Packages.dm-haiku
  • python310Packages.dm-haiku.dist
  • python310Packages.dm-haiku.testsout

@natsukium
Copy link
Member Author

python311Packages.dm-haiku will be fixed by #249146

@natsukium
Copy link
Member Author

python310Packages.{elegy,treex} will be marked as broken in #249149

@ofborg ofborg bot requested a review from ndl August 14, 2023 16:18
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 14, 2023
@natsukium natsukium merged commit 199b897 into NixOS:master Aug 22, 2023
12 checks passed
@natsukium natsukium deleted the dm-haiku/fix branch August 22, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant