mapnik: unstable-2022-10-18 -> unstable-2023-11-28

[hummeltech]

Description of changes

• Removed no-longer-needed patch:

  • include.patch: Fixed here

• Added patch to account for FONTS_INSTALL_DIR/PLUGINS_INSTALL_DIR containing full paths, causing this issue:

  Broken paths found in a .pc file! /nix/store/...-mapnik-unstable-2023-11-28/lib/pkgconfig/libmapnik.pc
  The following lines have issues (specifically '//' in paths).
  5:fonts_dir=${prefix}//nix/store/...-mapnik-unstable-2023-11-28/lib/mapnik/fonts
  6:plugins_dir=${prefix}//nix/store/...-mapnik-unstable-2023-11-28/lib/mapnik/input
  

• Enabled Checks, which requires a patch to allow one test to fail:

  • datasource-ogr-test-should-fail.patch

• Updated python-mapnik to latest upstream

  • Based on the proj6 branch (which currently has an open pull request)

This "release" also includes a patch which mod_tile is expecting for Mapnik versions >= 4:
Seen here

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[dotlambda]

Please squash.

[dotlambda]

The first line of commit message should be mapnik: unstable-2022-10-18 -> unstable-2023-11-28. You can mention the removed patch in the remainder.

[dotlambda]

Result of nixpkgs-review pr 277128 run on x86_64-linux 1

10 packages failed to build:

• apacheHttpdPackages.mod_tile (apacheHttpdPackages_2_4.mod_tile)
• mapnik
• perl536Packages.Tirex
• perl536Packages.Tirex.devdoc
• perl538Packages.Tirex
• perl538Packages.Tirex.devdoc
• python310Packages.python-mapnik
• python310Packages.python-mapnik.dist
• python311Packages.python-mapnik
• python311Packages.python-mapnik.dist

[hummeltech]

Hmm, yes I see that. I am not having any issues building it locally, and the logs are not showing any errors (which could indicate a visit by the OOM Killer). I have added a commit in order to attempt the build with enableParallelBuilding disabled, which is what previous versions of Mapnik did in order to build certain targets which required more RAM. And since the x86_64-darwin builds (which use -j1) are all building successfully, I think this might be a valid path. I cannot think of anything else to try at this time.

[hummeltech]

Nevermind, upon closer inspection of the logs, it looks like there is still an issue which requires cmake-harfbuzz.patch. I have re-included that patch. Not sure why it doesn't affect me.

[dotlambda]

Result of nixpkgs-review pr 277128 run on x86_64-linux 1

4 packages failed to build:

• python310Packages.python-mapnik
• python310Packages.python-mapnik.dist
• python311Packages.python-mapnik
• python311Packages.python-mapnik.dist

6 packages built:

• apacheHttpdPackages.mod_tile (apacheHttpdPackages_2_4.mod_tile)
• mapnik
• perl536Packages.Tirex
• perl536Packages.Tirex.devdoc
• perl538Packages.Tirex
• perl538Packages.Tirex.devdoc

[hummeltech]

I'm not sure why that was no longer working, I added python3Packages.boost to python-mapnik's propagatedBuildInputs as that being missing seemed to be causing the library (libboost_python310.so) to be missing, I.E.:

/nix/store/...-binutils-2.40/bin/ld: cannot find -lboost_python310: No such file or directory

[dotlambda]

I don't think it has anything to do with adding boost to propagatedBuildInputs. I get errors like

src/mapnik_enumeration.hpp:71:20: error: invalid ‘static_cast’ from type ‘const mapnik::enumeration<mapnik::gamma_method_enum, mapnik::gamma_method_e_to_string, mapnik::gamma_method_e_from_string, mapnik::gamma_method_e_lookup>’ to type ‘long int’
   71 |                 ,  static_cast<long>( v ));
      |                    ^~~~~~~~~~~~~~~~~~~~~~

and

src/mapnik_enumeration.hpp:71:20: error: invalid ‘static_cast’ from type ‘const mapnik::enumeration<mapnik::gamma_method_enum, mapnik::gamma_method_e_to_string, mapnik::gamma_method_e_from_string, mapnik::gamma_method_e_lookup>’ to type ‘long int’
   71 |                 ,  static_cast<long>( v ));
      |                    ^~~~~~~~~~~~~~~~~~~~~~

I think python-mapnik is simply not yet compatible with recent versions of mapnik.
I suggest you open an upstream issue and mark python-mapnik broken.

[dotlambda]

mapnik/python-mapnik#270 (comment) claims to have a fix but after applying that commit using fetchpatch it complains about C++20.

[hummeltech]

Alright @dotlambda, I figured out the python-mapnik issue and I now have nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD" running without errors on my machine. Let me know if it's working for you.

It looks like support for Proj >= 6 isn't completely merged into the default branch, so I tried out the proj6 branch (omitting the latest commits which break the build,) and everything builds again successfully.
mapnik/python-mapnik@master...proj6

The patch from your previous comment is included in the aforementioned branch.

[dotlambda]

The last commit message should be python311Packages.python-mapnik: unstable-2020-09-08 -> unstable-2023-02-23.

[dotlambda]

@hummeltech Do you want to add yourself as maintainer?

[hummeltech]

Sure, that's fine, shall I add myself onto the list?

[dotlambda]

Sure, that's fine, shall I add myself onto the list?

Yes, you'll first have to add yourself to maintainers/maintainer-list.nix in one commit and then to mapnik's meta.maintainers in a separate one.

[dotlambda]

Result of nixpkgs-review pr 277128 run on x86_64-linux 1

10 packages built:

• apacheHttpdPackages.mod_tile (apacheHttpdPackages_2_4.mod_tile)
• mapnik
• perl536Packages.Tirex
• perl536Packages.Tirex.devdoc
• perl538Packages.Tirex
• perl538Packages.Tirex.devdoc
• python310Packages.python-mapnik
• python310Packages.python-mapnik.dist
• python311Packages.python-mapnik
• python311Packages.python-mapnik.dist

[dotlambda]

Darwin fails but I don't have access to the darwin builder atm so I won't be able to fix it. That shouldn't stop us from updating though.