tere: 1.5.0 -> 1.5.1-unstable-2024-04-01

[ProducerMatt]

Description of changes

Updated to the latest version, as well as the latest dev version which contains fixes for 4 failing cargo tests. More details about the failing tests here

pbsds edit: fixes #298489

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[ProducerMatt]

Will fix #298489

[ProducerMatt]

Updated to latest dev version which fixes the issues with the test. Also corrected issues mentioned by @mrene, thank you.

[mrene]

Changes look good!

There is still a test failure under aarch64-darwin, it feels specific to nix's build environment so it could be skipped.

Test log

     Running tests/cli.rs (target/aarch64-apple-darwin/release/deps/cli-49276a274f19a142)

running 4 tests
test tests::first_run_prompt_accept ... FAILED
test tests::output_on_exit_without_cd ... ok
test tests::first_run_prompt_cancel ... ok
test tests::basic_run ... ok

failures:

---- tests::first_run_prompt_accept stdout ----
thread 'tests::first_run_prompt_accept' panicked at tests/cli.rs:132:5:
assertion `left == right` failed
  left: "Error: Io(Os { code: 30, kind: ReadOnlyFilesystem, message: \"Read-only file system\" })\r\n"
 right: "/private/tmp/nix-build-tere-1.5.1-unstable-2024-04-01.drv-0/.tmpOtGxew\r\n"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    tests::first_run_prompt_accept

test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.34s

error: test failed, to rerun pass `--test cli`

[arduano]

Result of nixpkgs-review pr 298527 run on x86_64-linux 1

1 package built:

• tere

[timon-schelling]

checkFlags = [ "--skip=first_run_prompt_accept" ];

Plus a comment on why the test should be skipped should be enough to resolve this right?

[ProducerMatt]

@mgunyho any ideas about this failing test? I figure I'll disable it since NixOS + aarch64 is such a niche, but wanted to ping you and see #298527 (comment)

[mgunyho]

Hm, that test creates a temporary folder and then tries to place a file in it, apparently the filesystem is read-only and that's why it's failing. It's weird that creating the temp folder succeeds though. But yeah, it can be skipped with --skip first_run_prompt_accept as mentioned. I suggest skipping that test only for this platform if possible, just to be sure.

[timon-schelling]

@ProducerMatt Anything new?

[ProducerMatt]

@timon-schelling My bad, I dropped the ball. Here's the version with the commented test. If this builds fine on ARM Darwin then we can merge away.

[timon-schelling]

@ProducerMatt I think u need to use stdenv.targetPlatform.system instead of system and accept stdenv as a parameter of the pkg function.

[ProducerMatt]

@timon-schelling done!

[timon-schelling]

Properly not getting merged before 24.05?

[timon-schelling]

@mrene

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3921

[pbsds]

fixes https://hydra.nixos.org/build/260562089 and https://hydra.nixos.org/build/260494209, but https://hydra.nixos.org/build/260624373 and https://hydra.nixos.org/build/260446230 still fails with new errors

I think disabling first_run_prompt_accept on x86_64-darwin also makes sense, consider stdenv.isDarwin.

I don't understand why aarch64-linux is looking for what to me seems like a cross linker:

error: linker `aarch64-linux-gnu-gcc` not found

[ProducerMatt]

I've pushed the suggested changes to GitHub but they haven't showed up yet. Hopefully it's not another of my long string of Git mistakes. 😬

[ProducerMatt]

It was, in fact, another of my long string of Git mistakes. 🙃

[pbsds]

It seems tere doesn't receive frequent attention in terms of PRs. Please mark aarch64-linux as meta.broken

[ProducerMatt]

Implemented this script described by @jyooru in #145726 (comment)

Let's see if it fixes aarch64-linux

[ProducerMatt]

@pbsds thank you for the feedback and the merge approval! Hope you have a good day! 🙂