Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handheld-daemon-ui: init at 3.2.1 #305027

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

toast003
Copy link
Contributor

Description of changes

New package: https://github.com/hhd-dev/hhd-ui/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@appsforartists
Copy link
Contributor

Was surprised to see an AppImage and did some digging:

@toast003
Copy link
Contributor Author

Not familiar with building npm/electron stuff from source and looking at the pr it seems kinda complicated, but I'll try and see if I can get it to work.

@toast003
Copy link
Contributor Author

toast003 commented Apr 18, 2024

I can't get this to build from source

EDIT: Yeah, I give up.
Can we get this merged as-is?

@toast003 toast003 mentioned this pull request Apr 27, 2024
13 tasks
@toast003 toast003 changed the title handheld-daemon-ui: init at 2.2.3 handheld-daemon-ui: init at 3.1.1 Jul 8, 2024
@SuperSandro2000
Copy link
Member

I've dropped the merge commit from the PR because that usually only causes trouble.

@appsforartists
Copy link
Contributor

You probably also want options.services.handheld-daemon.ui.enable to default to options.services.handheld-daemon.enable in nixos/modules/services/hardware/handheld-daemon.nix, and pull this package in when true.

@toast003
Copy link
Contributor Author

I wanted to add that on a different pr, since you need to add handheld-daemon-ui and lsof to handheld-daemon's service path for the steam/gamescope overlay to work, but I guess it does make sense to have that here

@toast003 toast003 changed the title handheld-daemon-ui: init at 3.1.1 handheld-daemon-ui: init at 3.2.1 Oct 8, 2024
@@ -31,6 +40,11 @@ in

restartIfChanged = true;

path = mkIf cfg.ui.enable [
pkgs.handheld-daemon-ui
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be wrapped inside the UI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants