zelda64recomp: init at 1.1.1-unstable-2025-03-14 #313013
Conversation
github-actions
bot
added
6.topic: python
8.has: maintainer-list (update)
|
Result of 13 packages built:
|
ofborg
bot
added
8.has: package (new)
|
Result of 1 package failed to build:
12 packages built:
|
|
Great work! Do we have concern for supporting only one hash for the ROM? There are a couple of different No-Intro ROMs (BigEndian, ByteSwapped), additional regions of the ROM may eventually be supported, some people may have some ancient non-No-intro ROMs, etc. Should we just say to acquire the latest No-Intro ROM (BigEndian) for Majora's Mask? Also, is the ROM required for build, or is it simply for convenience? Build error for me as well: |
|
Whoops, I had everything cached before changing the commits to versions, it should build now. The required rom is the only one mm-decomp currently supports. It's needed to generate the outputs required for zelda64recomp. |
|
Managed to successfully build on the first try. Attempting to run (with |
|
Can you describe your setup? or post a coredump? I'm trying to reproduce I'm on KDE wayland, 5700 XT, sddm wayland-only
|
|
I'm explicitly setting |
|
Yes, I'm seeing it now when enabling amdvlk, it wasn't crashing on the radeon drivers. |
|
I updated directx-shader-compiler and now it doesn't crash with amdvlk. |
|
Sorry didn't mean to ping as I was building that locally, I'll squash and remove |
qubitnano
changed the title
There was a problem hiding this comment.
Building & playing great still.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 313013
x86_64-linux
✅ 3 packages built:
- n64recomp
- z64decompress
- zelda64recomp
keenanweaver
added
the
12.approvals: 1
qubitnano
added
12.approvals: 2
wegank
added
12.approvals: 1
this is not obvious to me. here's an extremely similar PR in which links and build instructions were shared. demonstrably, someone can link it here. |
There was a problem hiding this comment.
non-buildable packages are a maintenance headache. if you have to use requireFile, there needs to be documentation somewhere for how to obtain the file / realize your derivation. i don't much care if that's in-repo, here on GH, or a link to the wiki: just something i can link people to and say "run these commands to reproduce the derivation".
|
take a look at |
wegank
removed
the
12.approvals: 1
There was a problem hiding this comment.
thanks for linking the guide in requireFile. it still forces a lot of burden onto the user, but it's better than being left to flail in the dark. i'll remove my PR block.
package output structure could be improved though.
ls -F ./result/bin
assets/ gamecontrollerdb.txt@ Zelda64Recompiled*
best to link only the executables into bin/ and keep the assets somewhere in share/ or even opt/.
| let | ||
|
|
||
| baseRom = requireFile { | ||
| name = "mm.us.rev1.rom.z64"; |
There was a problem hiding this comment.
can you lift baseRom into the call args section? e.g.
{
lib,
SDL2,
...
requireFile,
mm64baserom ? null,
}:
let
baseRom = if mm64baserom != null then mm64baserom else requireFile {
...
};
...this gives users the ability to provide their own baserom in whatever manner they prefer. for example, it would let me swap it out with fetchzip by just injecting my own mm64baserom expression into the package set like this.
|
qubitnano
changed the title
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 313013
x86_64-linux
✅ 3 packages built:
- n64recomp
- z64decompress
- zelda64recomp
wegank
added
the
12.approvals: 1
Description of changes
Closes #310947
https://github.com/Zelda64Recomp/Zelda64Recomp
Zelda 64: Recompiled is a project that uses N64: Recompiled to statically recompile Majora's Mask (and soon Ocarina of Time) into a native port with many new features and enhancements. This project uses RT64 as the rendering engine to provide some of these enhancements.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.