mumble: unpin protobuf#322756
Merged
yu-re-ka merged 1 commit intoNixOS:masterfrom Jun 30, 2024
yu-re-ka:musl-mumble
Merged
Conversation
alyssais
approved these changes
Jun 26, 2024
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
Did you test this before? The VM tests are failing. |
Contributor
Author
|
I tested that it still builds (under non-musl).
I did not test the functionality but it would surprise me a lot if it would break because archlinux is also building mumble against latest (27.x) protobuf.
Jun 27, 2024 2:19:15 AM Felix Singer ***@***.***>:
…
Did you test this before? The VM tests are failing.
—
Reply to this email directly, view it on GitHub[#322756 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AURNSZJVRDDTKI4XL54AXYDZJNLADAVCNFSM6AAAAABJ6XHHE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSHAZDQNBWGM].
You are receiving this because you authored the thread.
[Tracking image][https://github.com/notifications/beacon/AURNSZKOLR55SNBCWARDOGDZJNLADA5CNFSM6AAAAABJ6XHHE2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUCWPUC6.gif]
|
Member
|
It seems the CI built it, but the execution failed. I can try looking at it tomorrow. |
wegank
added
the
12.approvals: 1
fixes pkgsMusl.mumble after musl 1.2.5 upgrade
Contributor
Author
|
Looking at the CI logs again, it was the server ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes pkgsMusl.mumble after musl 1.2.5 upgrade (#229439)
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.