musl: refactor#328327
Closed
AndersonTorres wants to merge 5 commits intoNixOS:masterfrom
atorres1985-contrib:musl-master
Closed
musl: refactor#328327AndersonTorres wants to merge 5 commits intoNixOS:masterfrom atorres1985-contrib:musl-master
AndersonTorres wants to merge 5 commits intoNixOS:masterfrom
atorres1985-contrib:musl-master
Conversation
Member
Author
|
ofborg
bot
added
11.by: package-maintainer
Member
Author
|
Result of 2 packages marked as broken and skipped:
1 package blacklisted:
177 packages built:
|
Member
Author
|
Well, the effort on updating NetBSD's compat files will be done another day. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4290 |
superherointj
approved these changes
Jul 20, 2024
Member
Author
|
I will draft this a little bit because the compat package changed its name in Alpine. |
Member
|
This is duplicating effort from the very long running effort in #229439. Please help with broken packages, which is the reason this hasn't been finished yet, and if you want to refactor, please do that in a separate PR to not interfere with the upgrade work. |
Since theey is not active in a long span of time. Also, add AndersonTorres.
Well, let's go:
- The sources were detached to a separated file, so that we can track them more
easily.
- Indeed some files came from Alpine Linux aports repo, however they borrowed
from NetBSD; ideally we should pick them from their origins.
- The sources are treated as packages, with pname, version and src well-defined.
- The usage of null as default is too error-prone, as demonstrated by an old
Emacs refactor we did.
- I have grepped the Nixpkgs and I have not found references that nullified
linuxHeaders.
- finalAttrs design pattern
- SRI hashes
- Use `output*` variables
- strictDeps
- set as false so we can track it later when true
- env vars inside env
- Remove comments from Bash code
- Bash is to assembly as Nix is to Haskell.
Bash is plumbing, and comments inside it has few to no value; indeed they
have negative value, given that they are no-ops *and* cause mass rebuilds.
- A more or less elegant solution employed by our Emacs expression is to
concatenate strings.
- use pushd/popd instead of subshell
- passthru
- meta:
- get rid of nested with
- longDescription
Phew!
Member
Author
|
@alyssais that being said, I removed the version upgrade from this PR. Further, I created an entry for a musl team. What do you think? |
Member
Author
|
I will reopen this in a new repo later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Picking from #328072, since it does not mass-rebuild.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.