Merged
Conversation
cafkafk
force-pushed
the
init-nix-weather
branch
2 times, most recently
from
639b2f1 to
5658c35
Compare
Member
Author
|
@freyacodes I've added you as maintainer and co-author on this, and included some of the changes from #340477 (see https://github.com/NixOS/nixpkgs/compare/639b2f1a5c19cbeb760eaa63b24929c794e816df..5658c35d7fa10816a0d11d283ab197f6b7070a78). Hope that's okay :3 |
ofborg
bot
added
11.by: package-maintainer
freyacodes
approved these changes
Sep 8, 2024
Contributor
freyacodes
left a comment
freyacodes
left a comment
There was a problem hiding this comment.
New changes look good. It builds and runs just fine 👍
Member
|
Result of 2 packages failed to build:
|
wegank
reviewed
Sep 8, 2024
Changelog: https://git.fem.gg/cafkafk/nix-weather/releases/tag/v0.0.3 https://git.fem.gg/cafkafk/nix-weather/releases/tag/v0.0.2 Signed-off-by: Christina Sørensen <christina@cafkafk.com> Co-authored-by: Freya Arbjerg <freya@arbjerg.dev>
cafkafk
force-pushed
the
init-nix-weather
branch
from
5658c35 to
227afc4
Compare
Member
|
Result of 2 packages built:
|
Member
|
Result of 2 packages built:
|
wegank
approved these changes
Sep 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Changelog: https://git.fem.gg/cafkafk/nix-weather/releases/tag/v0.0.3 https://git.fem.gg/cafkafk/nix-weather/releases/tag/v0.0.2
Signed-off-by: Christina Sørensen christina@cafkafk.com
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.