Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] nvd: switch source repository to Sourcehut #345406

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

khumba
Copy link
Contributor

@khumba khumba commented Sep 30, 2024

Description of changes

nvd will be moving from Gitlab to Sourcehut shortly, and the old repository will be archived and then removed. There's also a new nvd release out and the bump on master is at the link below, but for 24.05 let's keep the same version -- the new nvd will get more testing on master and until 24.11 is out.

#345403

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

nvd will be moving from Gitlab to Sourcehut shortly, and the old
repository will be archived and removed, before NixOS 24.05 is
out of support.
Copy link
Contributor

@iFreilicht iFreilicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on aarch64_darwin with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 345406". Everything works just like before, I tested both the list and diff features.

The commit on sourcehut is exactly the same as the one one gitlab, as the unchanged src.hash indicates.

@JohnRTitor JohnRTitor merged commit 9603a11 into NixOS:release-24.05 Sep 30, 2024
26 checks passed
@khumba khumba deleted the nvd-srht-24.05 branch September 30, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants