Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow-cpp: 17.0.0 -> 18.0.0 #351868

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
25 changes: 14 additions & 11 deletions pkgs/by-name/ar/arrow-cpp/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
nlohmann_json,
openssl,
perl,
pkg-config,
protobuf,
python3,
rapidjson,
Expand All @@ -49,8 +50,8 @@
zstd,
testers,
enableShared ? !stdenv.hostPlatform.isStatic,
enableFlight ? true,
enableJemalloc ? !stdenv.hostPlatform.isDarwin,
enableFlight ? stdenv.buildPlatform == stdenv.hostPlatform,
enableJemalloc ? !stdenv.hostPlatform.isDarwin && !stdenv.hostPlatform.isAarch64,
enableS3 ? true,
enableGcs ? !stdenv.hostPlatform.isDarwin,
}:
Expand All @@ -65,28 +66,29 @@ let
name = "arrow-testing";
owner = "apache";
repo = "arrow-testing";
rev = "735ae7128d571398dd798d7ff004adebeb342883";
hash = "sha256-67KwnSt+EeEDvk+9kxR51tErL2wJqEPRITKb/dN+HMQ=";
rev = "4d209492d514c2d3cb2d392681b9aa00e6d8da1c";
hash = "sha256-IkiCbuy0bWyClPZ4ZEdkEP7jFYLhM7RCuNLd6Lazd4o=";
};

parquet-testing = fetchFromGitHub {
name = "parquet-testing";
owner = "apache";
repo = "parquet-testing";
rev = "74278bc4a1122d74945969e6dec405abd1533ec3";
hash = "sha256-WbpndtAviph6+I/F2bevuMI9DkfSv4SMPgMaP98k6Qo=";
rev = "a7f1d288e693dbb08e3199851c4eb2140ff8dff2";
hash = "sha256-zLWJOWcW7OYL32OwBm9VFtHbmG+ibhteRfHlKr9G3CQ=";
};

version = "18.0.0";
in
stdenv.mkDerivation (finalAttrs: {
pname = "arrow-cpp";
version = "17.0.0";
inherit version;

src = fetchFromGitHub {
owner = "apache";
repo = "arrow";
rev = "apache-arrow-17.0.0";
hash = "sha256-ZQqi1RFb4Ey0A0UVCThuIxM7DoFfkLwaeRAc2z8u9so=";
rev = "apache-arrow-${version}";
hash = "sha256-V2lOYOUJwXSvPPk2G17uc1eZO88EATHKwwDnEroBrPw=";
};

sourceRoot = "${finalAttrs.src.name}/cpp";
Expand Down Expand Up @@ -125,6 +127,7 @@ stdenv.mkDerivation (finalAttrs: {

nativeBuildInputs = [
cmake
pkg-config
ninja
autoconf # for vendored jemalloc
flatbuffers
Expand Down Expand Up @@ -171,15 +174,15 @@ stdenv.mkDerivation (finalAttrs: {
preConfigure = ''
patchShebangs build-support/
substituteInPlace "src/arrow/vendored/datetime/tz.cpp" \
--replace 'discover_tz_dir();' '"${tzdata}/share/zoneinfo";'
--replace-fail 'discover_tz_dir();' '"${tzdata}/share/zoneinfo";'
'';

cmakeFlags =
[
"-DCMAKE_FIND_PACKAGE_PREFER_CONFIG=ON"
"-DARROW_BUILD_SHARED=${if enableShared then "ON" else "OFF"}"
"-DARROW_BUILD_STATIC=${if enableShared then "OFF" else "ON"}"
"-DARROW_BUILD_TESTS=ON"
"-DARROW_BUILD_TESTS=${if enableShared then "ON" else "OFF"}"
"-DARROW_BUILD_INTEGRATION=ON"
"-DARROW_BUILD_UTILITIES=ON"
"-DARROW_EXTRA_ERROR_CONTEXT=ON"
Expand Down
5 changes: 5 additions & 0 deletions pkgs/development/libraries/gdal/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ stdenv.mkDerivation (finalAttrs: {
url = "https://github.com/OSGeo/gdal/commit/40c3212fe4ba93e5176df4cd8ae5e29e06bb6027.patch";
sha256 = "sha256-D55iT6E/YdpSyfN7KUDTh1gdmIDLHXW4VC5d6D9B7ls=";
})
(fetchpatch {
name = "arrow-18.patch";
url = "https://github.com/OSGeo/gdal/commit/9a8c5c031404bbc81445291bad128bc13766cafa.patch";
sha256 = "sha256-tF46DmF7ZReqY8ACTTPXohWLsRn8lVxhKF1s+r254KM=";
})
];

nativeBuildInputs = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
thrift,
requests,
urllib3,
fetchpatch,
}:

buildPythonPackage rec {
Expand All @@ -33,16 +32,9 @@ buildPythonPackage rec {
hash = "sha256-8q5qWN+i2mGbzXvkop/G6mjZegzZ/6kr1Fl7FaHwLYA=";
};

patches = [
(fetchpatch {
name = "fix-pandas.patch";
url = "https://patch-diff.githubusercontent.com/raw/databricks/databricks-sql-python/pull/416.patch";
sha256 = "sha256-sNCp8xSSmKP2yNzDK4wyWC5Hoe574AeHnKTeNcIxaek=";
})
];

pythonRelaxDeps = [
"pyarrow"
"thrift"
];

nativeBuildInputs = [
Expand Down
2 changes: 2 additions & 0 deletions pkgs/development/python-modules/datafusion/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
libiconv,
numpy,
protobuf,
protoc,
pyarrow,
Security,
SystemConfiguration,
Expand Down Expand Up @@ -55,6 +56,7 @@ buildPythonPackage rec {
nativeBuildInputs = with rustPlatform; [
cargoSetupHook
maturinBuildHook
protoc
];

buildInputs =
Expand Down
21 changes: 14 additions & 7 deletions pkgs/development/python-modules/ibis-framework/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ let
testBackends = [
"duckdb"
"sqlite"
"datafusion"
];

ibisTestingData = fetchFromGitHub {
Expand Down Expand Up @@ -92,17 +91,28 @@ buildPythonPackage rec {
url = "https://github.com/ibis-project/ibis/commit/a54eceabac1d6592e9f6ab0ca7749e37a748c2ad.patch";
hash = "sha256-j5BPYVqnEF9GQV5N3/VhFUCdsEwAIOQC0KfZ5LNBSRg=";
})

# remove after the 10.0 release
(fetchpatch {
name = "ibis-framework-arrow-18.patch";
url = "https://github.com/ibis-project/ibis/commit/5dc549b22c2eca29a11a31fb29deef7c1466a204.patch";
hash = "sha256-4i/g2uixdlkbE6x659wzZJ91FZpzwOVkF6ZeXkiCP3I=";
excludes = [
"poetry.lock"
"requirements-dev.txt"
];
})
];

nativeBuildInputs = [
build-system = [
poetry-core
poetry-dynamic-versioning
];

dontBypassPoetryDynamicVersioning = true;
env.POETRY_DYNAMIC_VERSIONING_BYPASS = lib.head (lib.strings.splitString "-" version);

propagatedBuildInputs = [
dependencies = [
atpublic
parsy
python-dateutil
Expand All @@ -128,12 +138,9 @@ buildPythonPackage rec {
pytest-xdist
] ++ lib.concatMap (name: optional-dependencies.${name}) testBackends;

dontUsePytestXdist = true;

pytestFlagsArray = [
"-m"
# tpcds and tpch are slow, so disable them
"'not tpcds and not tpch and (${lib.concatStringsSep " or " testBackends} or core)'"
"'${lib.concatStringsSep " or " testBackends} or core'"
];

disabledTests = [
Expand Down
12 changes: 11 additions & 1 deletion pkgs/tools/filesystems/ceph/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
, fetchurl
, fetchFromGitHub
, fetchPypi
, fetchpatch
, fetchpatch2

# Build time
, autoconf
Expand Down Expand Up @@ -314,6 +314,16 @@ in rec {
pname = "ceph";
inherit src version;

patches = [
(fetchpatch2 {
name = "ceph-s3select-arrow-18-compat.patch";
url = "https://github.com/ceph/s3select/commit/f333ec82e6e8a3f7eb9ba1041d1442b2c7cd0f05.patch";
hash = "sha256-21fi5tMIs/JmuhwPYMWtampv/aqAe+EoPAXZLJlOvgo=";
stripLen = 1;
extraPrefix = "src/s3select/";
})
];

nativeBuildInputs = [
autoconf # `autoreconf` is called, e.g. for `qatlib_ext`
automake # `aclocal` is called, e.g. for `qatlib_ext`
Expand Down
1 change: 1 addition & 0 deletions pkgs/top-level/python-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2920,6 +2920,7 @@ self: super: with self; {

datafusion = callPackage ../development/python-modules/datafusion {
inherit (pkgs.darwin.apple_sdk.frameworks) Security SystemConfiguration;
protoc = pkgs.protobuf;
};

datalad = callPackage ../development/python-modules/datalad { };
Expand Down