Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluez: 5.78 -> 5.79 #354965

Merged
merged 2 commits into from
Nov 18, 2024
Merged

bluez: 5.78 -> 5.79 #354965

merged 2 commits into from
Nov 18, 2024

Conversation

alyssais
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 11, 2024
@alyssais
Copy link
Member Author

I think the failing test was always intermittent, so I can't tell if it's actually fixed. If we see it again we might have to add that patch back, but let's try removing it.

@alyssais alyssais merged commit 83b7cf4 into NixOS:staging Nov 18, 2024
32 of 33 checks passed
@alyssais alyssais deleted the bluez-5.79 branch November 18, 2024 14:35
@trofi
Copy link
Contributor

trofi commented Nov 24, 2024

Bisect claims that 83b7cf4 bluez: 5.78 -> 5.79 broke python3Packages.python-dbusmock tests on x86_64-linux on staging as:

$ nix build --no-link -f. python3Packages.python-dbusmock -j1 -L
...
python3.12-python-dbusmock> =================================== FAILURES ===================================
python3.12-python-dbusmock> ____________________________ TestBlueZ5.test_agent _____________________________
python3.12-python-dbusmock> self = <tests.test_bluez5.TestBlueZ5 testMethod=test_agent>
python3.12-python-dbusmock>     def test_agent(self):
python3.12-python-dbusmock>         # Given BlueZ with the AgentManager1 interface
python3.12-python-dbusmock>         bluez = self.dbus_con.get_object("org.bluez", "/org/bluez")
python3.12-python-dbusmock>         # When bluetoothctl is started
python3.12-python-dbusmock>         out = _run_bluetoothctl("list")
python3.12-python-dbusmock>         # Then it reports that the agent was registered
python3.12-python-dbusmock>         if self.bluez5_version >= Version("5.57"):
python3.12-python-dbusmock> >           self.assertIn("Agent registered", out)
python3.12-python-dbusmock> E           AssertionError: 'Agent registered' not found in ['Waiting to connect to bluetoothd...', '\x1b[0m[SIGNAL] org.freedesktop.DBus.Mock.MethodCalled', '\x1b[0mAgent registered', '\x1b[0mlist', '\x1b[0mlist', '\x1b[0mquit', '\x1b[0m']
python3.12-python-dbusmock> tests/test_bluez5.py:567: AssertionError
python3.12-python-dbusmock> ----------------------------- Captured stderr call -----------------------------
python3.12-python-dbusmock> Unable to open mgmt_socket
python3.12-python-dbusmock> =========================== short test summary info ============================
python3.12-python-dbusmock> FAILED tests/test_bluez5.py::TestBlueZ5::test_agent - AssertionError: 'Agent registered' not found in ['Waiting to connect to blu...
python3.12-python-dbusmock> =========== 1 failed, 139 passed, 54 skipped, 3 deselected in 36.10s ===========

@alyssais
Copy link
Member Author

#359455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants