CouchDB: Add support for additional config files #358006
Open
+46
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to set the Admin Password via secrets. `configFile` must be writable which is why it isn't sufficient.
github-actions
bot
added
6.topic: nixos
NixOSInfra
added
the
12. first-time contribution
This is required to pass the `Build NixOS manual v2` check.
kusold
commented
Nov 22, 2024
| @@ -134,6 +151,13 @@ in { | |||
| Extra configuration. Overrides any other configuration. | |||
There was a problem hiding this comment.
I also don't know how you feel about converting extraConfig to be of type attrs, and then we can use lib.generators.toINI {} cfg.extraConfg to convert it.
It'd be a breaking change which is why I refrained from making it, but it feels more "nixy" to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Adds a new option to the couchdb module to specify additional config files. This allows users to set the Admin Password via secrets.
configFilemust be writable which is why it isn't sufficient.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.