-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
factoriolab: init at 3.8.1 #358014
factoriolab: init at 3.8.1 #358014
Conversation
8942f71
to
8477a1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch for packaging factoriolab ❤️
I have some minor feedback, but this looks otherwise ready to ship, though I'll try and test it locally first.
8477a1c
to
22cd9e8
Compare
22cd9e8
to
307abfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm recovering from a long trip home, and I'm not up for merging now as a result (though someone else could!) so I'll try to remember to test & merge tomorrow. :)
Closes: #356733
FactorioLab is a tool for calculating resource and factory requirements for factory games like Factorio, Dyson Sphere Program, Satisfactory, Captain of Industry, Techtonica and Final Factory.
Things done
Packaged the project. Since it's a static website it doesn't do very much on its own you need some kind of webserver to host it, such as nginx, or for personal deployment
python -m http.server
. Could write a nixos module for that but not sure that's necessary.nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.