Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factoriolab: init at 3.8.1 #358014

Merged
merged 1 commit into from
Nov 27, 2024
Merged

factoriolab: init at 3.8.1 #358014

merged 1 commit into from
Nov 27, 2024

Conversation

PatrickDaG
Copy link
Contributor

@PatrickDaG PatrickDaG commented Nov 21, 2024

Closes: #356733
FactorioLab is a tool for calculating resource and factory requirements for factory games like Factorio, Dyson Sphere Program, Satisfactory, Captain of Industry, Techtonica and Final Factory.

Things done

Packaged the project. Since it's a static website it doesn't do very much on its own you need some kind of webserver to host it, such as nginx, or for personal deployment python -m http.server. Could write a nixos module for that but not sure that's necessary.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for packaging factoriolab ❤️

I have some minor feedback, but this looks otherwise ready to ship, though I'll try and test it locally first.

pkgs/by-name/fa/factoriolab/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/fa/factoriolab/package.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm recovering from a long trip home, and I'm not up for merging now as a result (though someone else could!) so I'll try to remember to test & merge tomorrow. :)

@nbraud nbraud added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Nov 26, 2024
@nbraud
Copy link
Contributor

nbraud commented Nov 27, 2024

Works 🎉
screenshot showing FactorioLab loaded from localhost

@nbraud nbraud merged commit 2affc0e into NixOS:master Nov 27, 2024
34 of 35 checks passed
@PatrickDaG PatrickDaG deleted the pkg-factoriolab branch November 28, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: factoriolab
3 participants