google-cloud-sdk: fix gsutil #358015
Open
google-cloud-sdk: fix gsutil #358015
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neutral comment (not against or in favour), there is a preference of not including patches in branch (doing fetchPatch instead of embedding the patch directly in nixpkgs) As such, I would side with pinning the python version to 3.11 while upstream fixes the versions constraints. |
|
Unfortunately the source code is bundled in a package (google-cloud-sdk) where the location of the file is in a different location than the source repo (gsutil). So I cannot use the fetchPatch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a runtime issue with gsutil introduced by #356927. It is an alternative fix to #357355.
This happened due to a more strict Python version constraint that was added to gsutil as part of this new release:
GoogleCloudPlatform/gsutil@c8e2709
gsutilis working on Python 3.12 support:gsutilhas been running with Python 3.12 for some time and other people indicate that it works "fine".I added a
gsutilcheck to the install check phase to avoid a similar error happening in the future.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.