Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.openusd: fix build on darwin #369035

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

gador
Copy link
Member

@gador gador commented Dec 29, 2024

Due to an update to Clang 19 the compiler got stricter and will fail with

error: no member named '_Set' in 'SdfChildrenProxy<_View>'

Upstream has merged an fix, which this commit will pull

Ref: PixarAnimationStudios/OpenUSD#3442
Fix: PixarAnimationStudios/OpenUSD#3434

@ShaddyDC

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Due to an update to Clang 19 the compiler got stricter
and will fail with

```
error: no member named '_Set' in 'SdfChildrenProxy<_View>'
```

Upstream has merged an fix, which this commit will pull

Signed-off-by: Florian Brandes <[email protected]>
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 29, 2024
@ofborg ofborg bot requested a review from ShaddyDC December 29, 2024 12:31
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 29, 2024
Copy link
Contributor

@ShaddyDC ShaddyDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! I'm looking forward to the next release when we can remove all of those patches.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369035


x86_64-linux

❌ 1 package failed to build:
  • blender-hip
✅ 5 packages built:
  • blender
  • blendfarm
  • openusd
  • python312Packages.openusd
  • python313Packages.openusd

@gador
Copy link
Member Author

gador commented Dec 31, 2024

Changes look good to me! I'm looking forward to the next release when we can remove all of those patches.

Yeah, me too!

@gador gador merged commit feb6ac9 into NixOS:master Dec 31, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants