python311Packages.nbmake: disable parallelism

[gepbird]

Fixes #369767

• tests sometimes (~1 in 10) hang indefinitely, @mweinelt improved it in 97efe32 which is probably fine for hydra if it builds it (last time I checked it only built for python 3.12 and 3.13, but not for 3.11), but on lower end devices this is more prone to failing
• not fixed in this PR at the end: tests rarely (~1 in 100) fail due to trying to use >32k ports which are already taken, this was observed in multiple tests, seems safer to ignore all tests for this package:
  • tests/test_pytest_plugin.py::test_when_parallel_passing_nbs_then_ok (Build failure: python311Packages.nbmake #369767 (comment))
  • tests/test_pytest_plugin.py::test_when_init_then_passes (Tests fail often for different reasons treebeardtech/nbmake#129 (comment))
  • tests/test_nb_run.py::TestNotebookRun::test_when_empty_then_succeeds (Tests fail often for different reasons treebeardtech/nbmake#129)

I intentionally kept the test related dependencies and workaround after disabling tests, in case we can enable them later.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[mweinelt]

The nbmake build looks fairly stable on hydra, so I'd be opposed to disabling its test suite completely. And even the python311 package is cached for me right now.

[gepbird]

@mweinelt Now the python311 version is cached for me too, but when rebuilding on nixos-unstable 1-2 days ago, it attempted to build locally:

If this failure is so rare it shouldn't happen in the future (or at least the package will be cached), then I'm fine without disabling the tests as they can be useful to catch other failures. I think we should keep c8cc094 for local builds, it would only cost us about an extra minute of build time.

(by the way where do you see that table with eval columns and package rows? What I did before is go on hydra.nixos.org -> nixpkgs -> trunk -> choose an eval -> search for package)

[mweinelt]

(by the way where do you see that table with eval columns and package rows? What I did before is go on hydra.nixos.org -> nixpkgs -> trunk -> choose an eval -> search for package)

Instead of choosing an eval, select the jobs tab and search there across multiple evals.

I think we should keep c8cc094 for local builds, it would only cost us about an extra minute of build time.

Can we drop the pytest-xdist dependency instead?

[gepbird]

Can we drop the pytest-xdist dependency instead?

Sure, then we need to disable only one test which consistently fails without ptytest-xdist

Build log

nbmake> =================================== FAILURES ===================================                                                                                                                          
nbmake> ____________________ test_when_parallel_passing_nbs_then_ok ____________________                                                                                                                          
nbmake>                                                                                                                                                                                                           
nbmake> pytester = <Pytester PosixPath('/build/pytest-of-nixbld/pytest-0/test_when_parallel_passing_nbs_then_ok0')>                                                                                               
nbmake> testdir2 = None                                                                                                                                                                                           
nbmake>                                                                                                                                                                                                           
nbmake>     def test_when_parallel_passing_nbs_then_ok(pytester: Pytester, testdir2: Never):                                                                                                                      
nbmake>         [write_nb(passing_nb, Path(f"{i}.ipynb")) for i in range(20)]                                                                                                                                     
nbmake>                                                                                                                                                                                                           
nbmake>         hook_recorder = pytester.inline_run("--nbmake", "-n=auto")                                                                                                                                        
nbmake>                                                                                                                                                                                                           
nbmake> >       assert hook_recorder.ret == ExitCode.OK                                                                                                                                                           
nbmake> E       AssertionError: assert <ExitCode.USAGE_ERROR: 4> == <ExitCode.OK: 0>                                                                                                                              
nbmake> E        +  where <ExitCode.USAGE_ERROR: 4> = <class '_pytest.pytester.Pytester.inline_run.<locals>.reprec'>.ret                                                                                          
nbmake> E        +  and   <ExitCode.OK: 0> = ExitCode.OK                                                                                                                                                          
nbmake>                                                                                                                                                                                                           
nbmake> /build/source/tests/test_pytest_plugin.py:61: AssertionError                                                                                                                                              
nbmake> ----------------------------- Captured stderr call -----------------------------                                                                                                                          
nbmake> ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]                                                                                                                                          
nbmake> pytest: error: unrecognized arguments: -n=auto                                                                                                                                                            
nbmake>   inifile: None                                                                                                                                                                                           
nbmake>   rootdir: /build/pytest-of-nixbld/pytest-0/test_when_parallel_passing_nbs_then_ok0                                                                                                                       
nbmake>                                                                                                                                                                                                           
nbmake> =========================== short test summary info ============================                                                                                                                          
nbmake> FAILED tests/test_pytest_plugin.py::test_when_parallel_passing_nbs_then_ok - AssertionError: assert <ExitCode.USAGE_ERROR: 4> == <ExitCode.OK: 0>                                                         

Instead of choosing an eval, select the jobs tab and search there across multiple evals.

Thanks!

[gepbird]

Rebasing to fix merge conflict