-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uboot: 2024.10 -> 2025.01 #374482
base: master
Are you sure you want to change the base?
uboot: 2024.10 -> 2025.01 #374482
Conversation
I had to disable 2 ARMv6 targets since the build environment seems to be broken. There was no Rest of the targets built fine: at 17:32:06 ❯ ls result
ubootA20OlinuxinoLime ubootClearfog ubootNanoPCT4 ubootOlimexA64Teres1 ubootOrangePiZero ubootPine64LTS ubootQemuX86 ubootRock4CPlus ubootRockPro64 ubootUtilite
ubootA20OlinuxinoLime2EMMC ubootCM3588NAS ubootNanoPCT6 ubootOrangePi3 ubootOrangePiZero2 ubootPinebook ubootRaspberryPi2 ubootRock5ModelB ubootROCPCRK3399 ubootWandboard
ubootAmx335xEVM ubootCubieboard2 ubootNovena ubootOrangePi3B ubootOrangePiZero3 ubootPinebookPro ubootRaspberryPi3_32bit ubootRock64 ubootSheevaplug
ubootBananaPi ubootGuruplug ubootOdroidC2 ubootOrangePi5 ubootOrangePiZeroPlus2H5 ubootQemuAarch64 ubootRaspberryPi3_64bit ubootRock64v2 ubootSopine
ubootBananaPim3 ubootJetsonTK1 ubootOdroidXU3 ubootOrangePi5Plus ubootPcduino3Nano ubootQemuArm ubootRaspberryPi4_32bit ubootRockPi4 ubootTools
ubootBananaPim64 ubootLibreTechCC ubootOlimexA64Olinuxino ubootOrangePiPc ubootPine64 ubootQemuRiscv64Smode ubootRaspberryPi4_64bit ubootRockPiE ubootTuringRK1 @jmbaur did you encounter ARMv6 building issue when updating to 2024.10? |
I don't recall running into any issues building armv6 for 2024.10. Maybe something related to the recent gcc bump? |
Running |
6a7786b
to
e7f246d
Compare
9d8f60c
to
8ce9949
Compare
So the issue is caused by how U-Boot parses the host triplets. It does not have a match for Now everything builds: ❯ ls result
ubootA20OlinuxinoLime ubootCM3588NAS ubootNovena ubootOrangePi5 ubootPcduino3Nano ubootQemuRiscv64Smode ubootRaspberryPi4_64bit ubootRockPiE ubootUtilite
ubootA20OlinuxinoLime2EMMC ubootCubieboard2 ubootOdroidC2 ubootOrangePi5Plus ubootPine64 ubootQemuX86 ubootRaspberryPiZero ubootRockPro64 ubootWandboard
ubootAmx335xEVM ubootGuruplug ubootOdroidXU3 ubootOrangePiPc ubootPine64LTS ubootRaspberryPi ubootRock4CPlus ubootROCPCRK3399
ubootBananaPi ubootJetsonTK1 ubootOlimexA64Olinuxino ubootOrangePiZero ubootPinebook ubootRaspberryPi2 ubootRock5ModelB ubootSheevaplug
ubootBananaPim3 ubootLibreTechCC ubootOlimexA64Teres1 ubootOrangePiZero2 ubootPinebookPro ubootRaspberryPi3_32bit ubootRock64 ubootSopine
ubootBananaPim64 ubootNanoPCT4 ubootOrangePi3 ubootOrangePiZero3 ubootQemuAarch64 ubootRaspberryPi3_64bit ubootRock64v2 ubootTools
ubootClearfog ubootNanoPCT6 ubootOrangePi3B ubootOrangePiZeroPlus2H5 ubootQemuArm ubootRaspberryPi4_32bit ubootRockPi4 ubootTuringRK1
❯ ls result | wc
58 58 972 |
CC @K900 and @thefossguy since I don't have permission to request reviewers in this account. |
Maybe we just drop armv<7 targets at this point? Doesn't feel worth it. |
Doesn't feel much of a maintenance burden at this point. The issue is only relevant to cross compile. If anything, they can just serve as tests against our cross compile infrastructure. |
I mean there's no way in hell we're actually building those non-cross. |
Build tested with an expression based on #347188.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.