nom: 2.7.2 -> 2.7.3 #374522
Merged
nom: 2.7.2 -> 2.7.3 #374522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasew
reviewed
Jan 19, 2025
pkgs/by-name/no/nom/package.nix
Outdated
| @@ -5,13 +5,13 @@ | |||
| }: | |||
| buildGoModule rec { | |||
| pname = "nom"; | |||
| version = "2.7.2"; | |||
| version = "2.7.3"; | |||
|
|
|||
| src = fetchFromGitHub { | |||
| owner = "guyfedwards"; | |||
| repo = "nom"; | |||
| rev = "v${version}"; | |||
There was a problem hiding this comment.
Can do, but what's the reasoning behind that?
There was a problem hiding this comment.
The reason is that you don't want to accidentally fetch a branch with the same name.
|
Do this auto-update somehow? If not, can you add a update script? gitUpdater may update the vendor hash, if not use nix-update-script |
|
nadir-ishiguro
force-pushed
the
update-nom
branch
from
1a8c6ad to
4128ae7
Compare
matthiasbeyer
approved these changes
Jan 19, 2025
|
@matthiasbeyer merge not permitted (#305350): |
This is so annoying. 👎 |
wegank
added
12.approved-by: package-maintainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: guyfedwards/nom#118
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.