Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpnc: unstable-2021-11-04 -> unstable-2024-12-20 #375356

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

cything
Copy link
Contributor

@cything cything commented Jan 20, 2025

Changelog: https://github.com/streambinder/vpnc/commits/d58afaaafb6a43cb21bb08282b54480d7b2cc6ab/
Resolves #375281

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 20, 2025
@MrSom3body
Copy link
Contributor

Seems to work

@cything
Copy link
Contributor Author

cything commented Jan 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375356


x86_64-linux

❌ 1 package failed to build:
  • connman-gtk
✅ 7 packages built:
  • CuboCore.coretoppings
  • connman
  • connman-ncurses
  • connmanFull
  • connman_dmenu
  • networkmanager-vpnc
  • vpnc

@cything
Copy link
Contributor Author

cything commented Jan 21, 2025

❌ 1 package failed to build:

  • connman-gtk

This currently fails to build on hydra: https://hydra.nixos.org/build/286031301

EDIT: corresponding issue: #375681

@cything
Copy link
Contributor Author

cything commented Jan 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375356


x86_64-linux

✅ 8 packages built:
  • CuboCore.coretoppings
  • connman
  • connman-gtk
  • connman-ncurses
  • connmanFull
  • connman_dmenu
  • networkmanager-vpnc
  • vpnc

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375356


x86_64-linux

✅ 8 packages built:
  • CuboCore.coretoppings
  • connman
  • connman-gtk
  • connman-ncurses
  • connmanFull
  • connman_dmenu
  • networkmanager-vpnc
  • vpnc

aarch64-linux

✅ 8 packages built:
  • CuboCore.coretoppings
  • connman
  • connman-gtk
  • connman-ncurses
  • connmanFull
  • connman_dmenu
  • networkmanager-vpnc
  • vpnc

@GaetanLepage GaetanLepage merged commit 0c59837 into NixOS:master Jan 28, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Request: vpnc c8bb537 → d58afaa
3 participants