proxychains-ng: default to dyld hooking method #375602
Open
+19
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the build actually doesn't work in recent darwin versions because the new hooking method wasn't used.
About new dyld hooking method: rofl0r/proxychains-ng#409 and rofl0r/proxychains-ng@e20c08f
The default is
auto
and depends on a variable that probably doesn't exist in the nix sandbox, so it always falls back to the old hooking method.If it is enabled, we should see something like this in the build log
which I don't see in a recent hydra aarch64-darwin build: https://cache.nixos.org/log/n4rqgpqzqcwdd7vazjxi1gb7h36k3zqr-proxychains-ng-4.17.drv
Also bring in a hotfix because compile error: rofl0r/proxychains-ng@fffd253
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.