Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxychains-ng: default to dyld hooking method #375602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

usertam
Copy link
Contributor

@usertam usertam commented Jan 21, 2025

Right now the build actually doesn't work in recent darwin versions because the new hooking method wasn't used.
About new dyld hooking method: rofl0r/proxychains-ng#409 and rofl0r/proxychains-ng@e20c08f

The default is auto and depends on a variable that probably doesn't exist in the nix sandbox, so it always falls back to the old hooking method.

If it is enabled, we should see something like this in the build log

checking checking whether we can use -lpthread ... yes
using Monterey style DYLD hooking
Done, now run make && make install

which I don't see in a recent hydra aarch64-darwin build: https://cache.nixos.org/log/n4rqgpqzqcwdd7vazjxi1gb7h36k3zqr-proxychains-ng-4.17.drv

Also bring in a hotfix because compile error: rofl0r/proxychains-ng@fffd253

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@usertam usertam force-pushed the patch/proxychains-ng branch from 3ae6a2e to 49aeb65 Compare January 21, 2025 17:59
@usertam
Copy link
Contributor Author

usertam commented Jan 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • proxychains-ng

aarch64-linux

✅ 1 package built:
  • proxychains-ng

x86_64-darwin

✅ 1 package built:
  • proxychains-ng

aarch64-darwin

✅ 1 package built:
  • proxychains-ng

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants