nixVersions.nix_2_26: init at 2.26.1 #375856
Conversation
nix-owners
bot
requested review from
tomberek,
Ericson2314,
RaitoBezarius,
Mic92,
edolstra and
fricklerhandwerk
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
nativeBuildInputs = [ nix ] would have no effect before this change. The pkg-config test on the dev output probably didn't work before, so I've removed it for now.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
| }; | ||
|
|
||
| # TODO Hack until https://github.com/NixOS/nixpkgs/issues/45462 is fixed. | ||
| boost = |
There was a problem hiding this comment.
Just a heads up. We didn't use to have this override in nixpkgs. Question is if we want this now?
There was a problem hiding this comment.
Afaik this would only save us downloading icu.
| }).overrideAttrs | ||
| (old: { | ||
| # Need to remove `--with-*` to use `--with-libraries=...` | ||
| buildPhase = lib.replaceStrings [ "--without-python" ] [ "" ] old.buildPhase; |
There was a problem hiding this comment.
boost seems to not have python enabled by default. So we can drop the overrideAttrs here and in the nix repository.
There was a problem hiding this comment.
It seems that @Ericson2314 was working around something.
I don't know the intricacies of this.
There was a problem hiding this comment.
I've switched it to the default boost package for now.
| let | ||
| cpp = fileset.fileFilter (file: file.hasExt "cc" || file.hasExt "h"); | ||
| in | ||
| fileset.unions [ |
There was a problem hiding this comment.
I don't think filesets are allows in nixpkgs at the moment because of that nix bug.
There was a problem hiding this comment.
This is the tracking issue: #369694
There was a problem hiding this comment.
The filesets are intentionally dead code to keep the files similar to upstream.
So we're not affected by the bug, but we may remove these filesets anyway. I'm neither convinced to remove them nor keep them.
pkgs/tools/package-management/nix/2_26/src/internal-api-docs/package.nix
Show resolved
Hide resolved
pkgs/tools/package-management/nix/2_26/src/libexpr-test-support/package.nix
Show resolved
Hide resolved
pkgs/tools/package-management/nix/2_26/src/libfetchers-tests/package.nix
Show resolved
Hide resolved
pkgs/tools/package-management/nix/2_26/src/libstore-test-support/package.nix
Show resolved
Hide resolved
pkgs/tools/package-management/nix/2_26/src/libutil-test-support/package.nix
Show resolved
Hide resolved
roberth
changed the title
This is the first Nixpkgs build of Nix that uses meson and uses the componentized build.
Related
Future versions may use a similar method of packaging (copying files mostly as-is), or we could "make it our own" here in Nixpkgs and support multiple versions using conditionals, etc.
This initial version probably leaves one or two things to be desired, but let's get the ball rolling first.
TODO
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Context:
Add a 👍 reaction to pull requests you find important.