oterm: 0.8.0 -> 0.8.1 #378400
Open
oterm: 0.8.0 -> 0.8.1 #378400
+106
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
textualeffects: integrate code-review comments textualeffects: integrate code-review comments
github-actions
bot
added
6.topic: python
8.has: maintainer-list (update)
|
|
||
| pythonImportsCheck = [ "mcp" ]; | ||
|
|
||
| # no tests implemented |
There was a problem hiding this comment.
What is this https://github.com/modelcontextprotocol/python-sdk/tree/main/tests then?
There was a problem hiding this comment.
Thanks for pointing this out ; i fixed this oversight
| @@ -14,7 +14,7 @@ | |||
| let | |||
| self = buildPythonPackage rec { | |||
| pname = "pydantic-settings"; | |||
| version = "2.5.2"; | |||
| version = "2.7.1"; | |||
There was a problem hiding this comment.
Is this absolutely necessary? Because that must go to staging and probably causes regressions
There was a problem hiding this comment.
Yes, MCP needed this version to build unfortunately.
There was a problem hiding this comment.
Try pythonRelaxDeps = [ "pydantic-settings" ] instead.
Upstream also relaxed the requirement modelcontextprotocol/python-sdk@0d48a44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.