Skip to content

python3Packages.vllm: 0.6.2 -> 0.7.1#379165

Merged
prusnak merged 5 commits intoNixOS:masterfrom
prusnak:vllm
Feb 4, 2025
Merged

python3Packages.vllm: 0.6.2 -> 0.7.1#379165
prusnak merged 5 commits intoNixOS:masterfrom
prusnak:vllm

Conversation

@prusnak
Copy link
Copy Markdown
Member

@prusnak prusnak commented Feb 3, 2025

This is a rebased PR #351805 with some of the changes from PR #359609 and should be viewed as the continuation of these two efforts

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 3, 2025
@prusnak prusnak requested a review from bgamari February 3, 2025 19:17
@prusnak prusnak force-pushed the vllm branch 2 times, most recently from 25ac5a4 to 85a6f45 Compare February 3, 2025 19:44
@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 3, 2025
@prusnak prusnak force-pushed the vllm branch 2 times, most recently from da5e946 to 02ee922 Compare February 3, 2025 22:39
prusnak and others added 2 commits February 4, 2025 10:08
Co-Authored-By: Ben Gamari <ben@smart-cactus.org>
Co-Authored-By: Pavol Rusnak <pavol@rusnak.io>
@github-actions github-actions Bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Feb 4, 2025
@prusnak
Copy link
Copy Markdown
Member Author

prusnak commented Feb 4, 2025

It seems that recent releases of vllm require xgrammar which is pain to build from source.

The PyPI provided wheels do not include aarch64-linux yet. Issue for inclusion of aarch64-linux wheels is here: mlc-ai/xgrammar#172

@prusnak prusnak removed the request for review from bgamari February 4, 2025 13:57
@prusnak prusnak marked this pull request as ready for review February 4, 2025 13:59
@nix-owners nix-owners Bot requested a review from natsukium February 4, 2025 14:00
@prusnak
Copy link
Copy Markdown
Member Author

prusnak commented Feb 4, 2025

The vllm now builds on my machine, but I cannot test it because I have an old GPU card (CC 5.2) :-/

@prusnak
Copy link
Copy Markdown
Member Author

prusnak commented Feb 4, 2025

I am going to merge this as is now, but feel free to send any subsequent PRs @conroy-cheers @bgamari and tag me in them. I will review and possibly test.

Thank you again!

@github-actions github-actions Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Feb 4, 2025
@prusnak prusnak merged commit ab36ef1 into NixOS:master Feb 4, 2025
@prusnak prusnak deleted the vllm branch February 4, 2025 14:09
@prusnak
Copy link
Copy Markdown
Member Author

prusnak commented Feb 4, 2025

It seems that recent releases of vllm require xgrammar which is pain to build from source.

Managed to do so in PR #379415 🎉

@prusnak prusnak mentioned this pull request Feb 5, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants