python3Packages.vllm: 0.6.2 -> 0.7.1#379165
Merged
prusnak merged 5 commits intoNixOS:masterfrom Feb 4, 2025
Merged
Conversation
This was referenced Feb 3, 2025
Closed
25ac5a4 to
85a6f45
Compare
da5e946 to
02ee922
Compare
Co-Authored-By: Ben Gamari <ben@smart-cactus.org> Co-Authored-By: Pavol Rusnak <pavol@rusnak.io>
Member
Author
|
It seems that recent releases of vllm require xgrammar which is pain to build from source. The PyPI provided wheels do not include aarch64-linux yet. Issue for inclusion of aarch64-linux wheels is here: mlc-ai/xgrammar#172 |
Member
Author
|
The |
Member
Author
|
I am going to merge this as is now, but feel free to send any subsequent PRs @conroy-cheers @bgamari and tag me in them. I will review and possibly test. Thank you again! |
Member
Author
Managed to do so in PR #379415 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebased PR #351805 with some of the changes from PR #359609 and should be viewed as the continuation of these two efforts
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.