yazi: replace optional svg dependency #397148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 1
nix-owners
bot
requested review from
XYenon,
eljamm,
khaneliman,
linsui,
matthiasbeyer and
uncenter
Member
|
imagemagick should be reserved for processing images in other formats |
Contributor
Yeah, looks like magick is still used https://github.com/sxyazi/yazi/blob/99ea3b74c4260a724b43af812df0f68ef59395b7/yazi-config/preset/yazi-default.toml#L101 and https://github.com/sxyazi/yazi/blob/99ea3b74c4260a724b43af812df0f68ef59395b7/yazi-plugin/preset/plugins/magick.lua#L50 |
replace imagemagick with resvg for reference see: NixOS#397092 (comment) yazi: add optional dependency `resvg`
This reverts commit aa7fc651bb09f2654398a501c6b67a12cc2b05b1.
Contributor
Author
|
um that's not what I wanted git to do (thanks, random stackoverflow answer) |
Contributor
Author
|
Sorry I don't get git. Follow up #397166. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace imagemagick with resvg
for reference see:
#397092 (comment)
SVG preview still works for me, additional testing would be appreciated
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.