Skip to content

Conversation

@guylamar2006
Copy link
Contributor

@guylamar2006 guylamar2006 commented Jul 4, 2025

Refactor rev = version; to tag = version;

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 4, 2025
@guylamar2006
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 422472

Logs: https://github.com/guylamar2006/nixpkgs-review-gha/actions/runs/16078781485

@wolfgangwalther
Copy link
Contributor

Did you check each of the github repos to confirm that none of those actually point at a branch with the version name and not to a tag?

@wolfgangwalther
Copy link
Contributor

Tested basic functionality of all binary files (usually in ./result/bin/)

You checked this box. Did you really test each package's binaries? Even considering that none of them were rebuilt?

@numinit
Copy link
Contributor

numinit commented Jul 4, 2025

This and #422131 are going to need a bit more. I currently cannot verify that this or the other change are correct. In general, changes to FODs have the potential of breaking things because the hash is used to cache the output.

Now, if there's a script you've got that changes each of these one at a time, and then makes sure the fetch works the same (think a Nix build command that uses --check, see https://nix.dev/manual/nix/2.25/advanced-topics/diff-hook) then it would be much easier for folks to verify. 🙂

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 20, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 1, 2026
@marcin-serwin marcin-serwin added the 2.status: needs-changes This PR needs changes by the author label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: needs-changes This PR needs changes by the author 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants