-
-
Notifications
You must be signed in to change notification settings - Fork 18k
mdbook: 0.4.52 -> 0.5.0 #462777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mdbook: 0.4.52 -> 0.5.0 #462777
Conversation
9389de2
|
After removing the patch the |
|
Nix and Lix builds are broken with the 0.5 version. See NixOS/nix#14628 and https://git.lix.systems/lix-project/lix/issues/1051 I suggest we revert as I see no other quick path to a working system. |
|
For Lix https://git.lix.systems/lix-project/lix/issues/1051 has been fixed in https://git.lix.systems/lix-project/lix/commit/54df89f601b3b4502a5c99173c9563495265d7e7 This allows building of Lix with any version of mdbook between 0.4.52 and 0.5.1 inclusive. |
|
We will almost certainly need to introduce a mdbook_0_5 variant because we build old Nix versions that would otherwise break. Thus we need to keep mdbook_0_4 around at least for the next 4 Nix releases unless Nix backports the change to their old versions. |
|
Since at least the mermaid plugin is currently out of sync with the I've opened #467009 including patches, for now, because iiuc the Nix team is about to make releases. I saw that the Lix patches also haven't quite made it into Nixpkgs yet. If it's useful, here's what I got: $ nix-build -A lix
[...]
--- stderr ---
INFO Book building has started
python3: can't open file '/build/source/doc/manual/doc/manual/substitute.py': [Errno 2] No such file or directory
jq: Could not open doc/manual/anchors.jq: No such file or directory
WARN Error writing the RenderContext to the backend, Broken pipe (os error 32)
ERROR The "anchors" preprocessor exited unsuccessfully with exit status: 2 status
ninja: build stopped: subcommand failed.
error: Cannot build '/nix/store/a0zbgkbhb7gripzdkgn79kbgdx7qz45m-lix-2.93.3.drv'It seems practical to move the conversation to #467009 |
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/rust-lang/mdBook/releases.
meta.description for mdbook is: Create books from MarkDown
meta.homepage for mdbook is: https://github.com/rust-lang/mdBook
meta.changelog for mdbook is: https://github.com/rust-lang/mdBook/blob/v0.5.0/CHANGELOG.md
Updates performed
To inspect upstream changes
Impact
Checks done
Caution
A test defined in
passthru.testsdid not pass.Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from the cache:
(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Maintainer pings
cc @Frostman @matthiasbeyer for testing.
Tip
As a maintainer, if your package is located under
pkgs/by-name/*, you can comment@NixOS/nixpkgs-merge-bot mergeto automatically merge this update using thenixpkgs-merge-bot.Add a 👍 reaction to pull requests you find important.