Skip to content

Conversation

@gonsolo
Copy link
Contributor

@gonsolo gonsolo commented Dec 17, 2025

A SWIG-based Python wrapper around Yosys's libparse, for all your dotlib file parsing needs.
https://github.com/librelane/libparse-python

This is a prerequisite for librelane, coming later.

It depends on #471062.

  • Built on platform:
    • [x ] x86_64-linux

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Dec 17, 2025
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I covered the majority of points that should be addressed in my review, and I hope that my comments are clear, but don't hesitate to ask if you have any questions.

Also, please don't forget to squash your changes and correctly format the PR and commit name at the end.

@gonsolo gonsolo changed the title Libparse python libparse-python: init at 0-unstable-2025-12-15 Dec 19, 2025
@nixpkgs-ci nixpkgs-ci bot requested a review from natsukium December 19, 2025 16:20
@nixpkgs-ci nixpkgs-ci bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 19, 2025
@gonsolo
Copy link
Contributor Author

gonsolo commented Dec 19, 2025

I think I covered the majority of points that should be addressed in my review, and I hope that my comments are clear, but don't hesitate to ask if you have any questions.

Thanks, I updated according to your suggestions. Please have a second look since the changes were quite intrusive.

Also, please don't forget to squash your changes and correctly format the PR and commit name at the end.

Done.

@gonsolo gonsolo force-pushed the libparse-python branch 3 times, most recently from 89a3760 to b514c11 Compare December 21, 2025 10:58
@gonsolo
Copy link
Contributor Author

gonsolo commented Dec 21, 2025

I think I addressed all comments now.
Thanks for reviewing, @eljamm and @donn!

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Dec 21, 2025
@donn donn self-requested a review December 21, 2025 16:12
@gonsolo
Copy link
Contributor Author

gonsolo commented Jan 2, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 471693
Commit: b514c116de6c3ea0484d8370ecfb3151ec1d4edc


x86_64-linux

✅ 4 packages built:
  • python312Packages.libparse-python
  • python312Packages.libparse-python.dist
  • python313Packages.libparse-python
  • python313Packages.libparse-python.dist

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 471693
Commit: b514c116de6c3ea0484d8370ecfb3151ec1d4edc


x86_64-linux

✅ 4 packages built:
  • python312Packages.libparse-python
  • python312Packages.libparse-python.dist
  • python313Packages.libparse-python
  • python313Packages.libparse-python.dist

aarch64-linux

✅ 4 packages built:
  • python312Packages.libparse-python
  • python312Packages.libparse-python.dist
  • python313Packages.libparse-python
  • python313Packages.libparse-python.dist

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GaetanLepage GaetanLepage added this pull request to the merge queue Jan 4, 2026
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 4, 2026
Merged via the queue into NixOS:master with commit 5907a68 Jan 4, 2026
30 of 32 checks passed
@gonsolo gonsolo deleted the libparse-python branch January 7, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants