-
-
Notifications
You must be signed in to change notification settings - Fork 17.8k
librelane: init at 3.0.0.dev47-unstable-2026-01-16 #471712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
b986f63 to
8e9fc39
Compare
Dvd-Znf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you accidentally included commits other than librelane: init at 3.0.0.dev45 by maybe branching from anothers PR branch instead of clean master
you can try using git rebase -i to remove the other commits
All the commits are dependencies of librelane. I rebased onto them to be able to nix build librelane before all of them are upstream. I converted this PR to a draft for now. |
|
Just a note: OpenROAD must be built with Python packages and the ability to load libraries and be available to LibreLane for LibreLane to actually fully work in Nix ( The overlays we use to get LibreLane working entirely in Nix are not up to nixpkgs standards and they would take a monumental effort to get them there. That's why I haven't bothered myself. https://github.com/librelane/librelane/blob/c68e32b888bb5f42fec75fa0d8bcc7fb8c994ab6/default.nix |
That's very good to know!
Ok.
Ok, I'll have a look. |
It does now.
I didn't look very close at those. @donn Can you take a look whether I forgot something? As mentioned above, the smoke test works for me now. |
|
If |
Cool, thanks.
I see click in Yosys's package.nix, and grepping through OpenROAD seems to wanting to install it, but I can find no use. |
|
Mostly LGTM, need to sit down and test it now. Really busy so might take a while. |
|
2b9ec30 to
2c326cb
Compare
|
|
I applied your suggestions, @GaetanLepage, thanks for reviewing! |
|
Maybe you already answered this, but wouldn't it work to fetch the |
I would have to apply a second PR since that release: I expect the newer PR 844 to be merged before a dev48, after which I would immediately update librelane in Nix, dropping the patch(es). It can be done before or after merging, I'm just committed to get it merged. :) |
7ef7155 to
45702f3
Compare
@GaetanLepage: The patch was added to the dev branch of librelane. I updated the revision and dropped the patch. |
|
|
|
The commit message and PR name should match the version: |
Done. |
Co-authored-by: Mohamed Gaber <[email protected]> Co-authored-by: Gaétan Lepage <[email protected]>
I changed to librelane: init at 3.0.0.dev47-unstable-2026-01-16, since the patch from today was added. |
GaetanLepage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ASIC implementation flow infrastructure, successor to OpenLane
https://github.com/librelane/librelane
./result/bin/.