-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
armitage: fix build with jdk17 + gradle_8 #478322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the Armitage build failure caused by the switch to Gradle 8 in Nixpkgs. Gradle 8.x requires Java 17 or newer for its build daemon, which was causing crashes with the previous jdk11 configuration.
- Switched build-time Java environment from
jdk11tojdk17innativeBuildInputs - Maintained
jdk11at runtime for application compatibility per upstream requirements
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
armitage on nixos-25.11 builds fine so no need to backport |
|
|
The switch to Gradle 8 in Nixpkgs caused the Armitage build to fail.
Gradle 8.x requires Java 17 or newer to run its daemon, but the derivation was still using
jdk11innativeBuildInputs.This caused the Gradle daemon's JVM to crash during startup, with the error "Gradle build daemon disappeared unexpectedly".
This commit fixes the build by switching the build-time Java environment to
jdk17fornativeBuildInputs, satisfying Gradle's requirement.The runtime Java version in the wrapper is kept at
jdk11, as upstream's README explicitly states that newer Java versions (e.g., 18) "break EVERYTHING", makingjdk11the safest choice for runtime compatibility.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.