Skip to content

oku: use system oniguruma and fix build with gcc15 #478324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eljamm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

oku: use system oniguruma and fix build with gcc15 #478324

eljamm wants to merge 1 commit into from
+5 −0

Conversation

@eljamm
Copy link
Contributor

@eljamm eljamm commented Jan 9, 2026 •
edited
Loading

Tracking #475479

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@eljamm eljamm marked this pull request as ready for review January 9, 2026 08:34
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 9, 2026
@eljamm
Copy link
Contributor Author

eljamm commented Jan 9, 2026

Nixos test is passing locally on x86_64-linux:

nix-build -A nixosTests.oku
nix build github:eljamm/nixpkgs/fix/oku#nixosTests.oku -L

@eljamm
Copy link
Contributor Author

eljamm commented Jan 9, 2026

nixpkgs-review result for #478324

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 478324
Commit: 17a3ae7d07e8a7e8fb187fd6cdec338271d33faa (subsequent changes)
Merge: 3fd1b8f68015c4c2f02bb9d76d0e5300da2453a6

Logs: https://github.com/eljamm/nixpkgs-review-gha/actions/runs/20846053341

x86_64-linux

✅ 1 package built:
  • oku

aarch64-linux

✅ 1 package built:
  • oku

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@eljamm eljamm requested a review from imincik January 9, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethancedwards8 ethancedwards8 Awaiting requested review from ethancedwards8

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

@OPNA2608 OPNA2608 Awaiting requested review from OPNA2608

@Prince213 Prince213 Awaiting requested review from Prince213

@wegank wegank Awaiting requested review from wegank

@imincik imincik Awaiting requested review from imincik

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eljamm