nixos/nixos-containers: fix interface name escaping in systemd.device unit name #478341
+41
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd escapes interface names in generated .device units. e.g.
dummy-test -> dummy\x2dtestWhen a non-alphanumeric interface (e.g. dummy-test) is set in
containers.<name>.interfacesand autoStart is enabled, systemd will wait for a wrong device, resulting a 5 minutes delay to start the container. Logs:This pr will fix this.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.