Skip to content

Conversation

@themadbit
Copy link
Contributor

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 9, 2026
@themadbit
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 478347
Commit: ceccf826d23128ad111f117f94f15dd788b773de (subsequent changes)
Merge: 8d7135551840356462a21e002cea519246a613fd

Logs: https://github.com/themadbit/nixpkgs-review-gha/actions/runs/20847998103


x86_64-linux

✅ 1 package built:
  • holo-cli

aarch64-linux

✅ 1 package built:
  • holo-cli

x86_64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • holo-cli

Error logs: `x86_64-darwin`
holo-cli
  -- Configuring incomplete, errors occurred!

--- stderr
CMake Error at /nix/store/zn5d8gi074jvlj2b05afp7cp0f3b1cj1-cmake-4.1.2/share/cmake-4.1/Modules/FindPackageHandleStandardArgs.cmake:227 (message):
Could NOT find PCRE2 (missing: PCRE2_LIBRARY) (Required is at least version
"10.21")
Call Stack (most recent call first):
/nix/store/zn5d8gi074jvlj2b05afp7cp0f3b1cj1-cmake-4.1.2/share/cmake-4.1/Modules/FindPackageHandleStandardArgs.cmake:591 (_FPHSA_FAILURE_MESSAGE)
CMakeModules/FindPCRE2.cmake:63 (find_package_handle_standard_args)
CMakeLists.txt:409 (find_package)

thread 'main' (71946) panicked at /nix/build/nix-9054-1298114174/holo-cli-0.5.0-unstable-2025-12-19-vendor/cmake-0.1.54/src/lib.rs:1119:5:

command did not execute successfully, got: exit status: 1

build script failed, must exit now
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...


aarch64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • holo-cli

Error logs: `aarch64-darwin`
holo-cli
  -- Configuring incomplete, errors occurred!

--- stderr
CMake Error at /nix/store/syg57akx2cvcc8kamsravsxf1gypwvlv-cmake-4.1.2/share/cmake-4.1/Modules/FindPackageHandleStandardArgs.cmake:227 (message):
Could NOT find PCRE2 (missing: PCRE2_LIBRARY) (Required is at least version
"10.21")
Call Stack (most recent call first):
/nix/store/syg57akx2cvcc8kamsravsxf1gypwvlv-cmake-4.1.2/share/cmake-4.1/Modules/FindPackageHandleStandardArgs.cmake:591 (_FPHSA_FAILURE_MESSAGE)
CMakeModules/FindPCRE2.cmake:63 (find_package_handle_standard_args)
CMakeLists.txt:409 (find_package)

thread 'main' (51744) panicked at /nix/build/nix-7365-77939284/holo-cli-0.5.0-unstable-2025-12-19-vendor/cmake-0.1.54/src/lib.rs:1119:5:

command did not execute successfully, got: exit status: 1

build script failed, must exit now
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

@themadbit themadbit marked this pull request as draft January 9, 2026 13:00
@Prince213
Copy link
Member

Is this PR superseding #473191?

@themadbit
Copy link
Contributor Author

It should if I fix the darwin build failures.

@Prince213
Copy link
Member

From the build logs it seems to be caused by missing dependencies. I'll look into it.

@themadbit
Copy link
Contributor Author

looks like its pcre2. I only can confirm/work on it using this PR as I don't have a darwin machine to build/test on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants