termcap: fix build with gcc15 #478354
Open
termcap: fix build with gcc15 #478354
+114
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ISO C23, which is the default in GCC 15, changes the meaning of an empty argument list from an unspecified list to no arguments, thus breaking the build. This patch fixes that by specifying all the arguments. Note: this fix was possible thanks to a similar patch: https://github.com/NixOS/nixpkgs/blob/ed124dcd6e5e07395c7d7ec77cd54a962f59bedc/pkgs/by-name/sh/sharutils/gcc15-c23-port.patch
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
eljamm
commented
Jan 9, 2026
| url = "https://github.com/msys2/MINGW-packages/raw/c6691ad1bd9d4c6823a18068ca0683c3e32ea005/mingw-w64-termcap/0001-tparam-replace-write-with-fprintf.patch"; | ||
| hash = "sha256-R9XaLfa8fzQBt+M+uA1AFTvKYCeOWLUD/7GViazXwto="; | ||
| }) | ||
| ./0001-Fix-too-many-arguments-to-function-with-GCC15-C23.patch |
Contributor
Author
There was a problem hiding this comment.
Now that I think about it, perhaps a better solution would be to change the std, similar to what fedora does?
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ISO C23, which is the default in GCC 15, changes the meaning of an empty argument list from an unspecified list to no arguments, thus breaking the build.
This patch fixes that by specifying all the arguments.
Note: this fix was possible thanks to a similar patch: https://github.com/NixOS/nixpkgs/blob/ed124dcd6e5e07395c7d7ec77cd54a962f59bedc/pkgs/by-name/sh/sharutils/gcc15-c23-port.patch
Tracking: #475479
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.