Skip to content

harper: 1.4.0 -> 1.4.1 #478366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
khaneliman merged 1 commit into from
Jan 12, 2026
Merged

harper: 1.4.0 -> 1.4.1 #478366

khaneliman merged 1 commit into from
Jan 12, 2026
+4 −4

Conversation

@ddogfoodd
Copy link
Contributor

@ddogfoodd ddogfoodd commented Jan 9, 2026

Changelog: https://github.com/Automattic/harper/releases/tag/v1.4.1
Diff: Automattic/harper@v1.4.0...v1.4.1

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. labels Jan 9, 2026
@MasterEvarior

This comment was marked as outdated.

Sign in to view
@ddogfoodd
Copy link
Contributor Author

ddogfoodd commented Jan 9, 2026

@MasterEvarior hm, somehow got the wrong hash. Could you test again, please?

@MasterEvarior
Copy link
Contributor

MasterEvarior commented Jan 9, 2026

@ddogfoodd Sure thing

@MasterEvarior
Copy link
Contributor

MasterEvarior commented Jan 9, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 478366
Commit: c1dcc5a40dd08c5a04107b6436a770acb452db7e (subsequent changes)
Merge: d71a9ef9411defd374ec9b49cff966152eab8191

Logs: https://github.com/MasterEvarior/nixpkgs-review-gha/actions/runs/20866637338

x86_64-linux

✅ 2 packages built:
  • harper
  • vscode-extensions.elijah-potter.harper

aarch64-linux

✅ 2 packages built:
  • harper
  • vscode-extensions.elijah-potter.harper

x86_64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • harper
  • vscode-extensions.elijah-potter.harper

aarch64-darwin (sandbox = relaxed)

✅ 2 packages built:
  • harper
  • vscode-extensions.elijah-potter.harper

MasterEvarior
MasterEvarior approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 9, 2026
sumnerevans
sumnerevans approved these changes Jan 11, 2026
View reviewed changes
Copy link
Contributor

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 478366
Commit: c1dcc5a40dd08c5a04107b6436a770acb452db7e

x86_64-linux

✅ 2 packages built:
  • harper
  • vscode-extensions.elijah-potter.harper

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jan 11, 2026
@khaneliman khaneliman added this pull request to the merge queue Jan 12, 2026
Merged via the queue into NixOS:master with commit d28e6eb Jan 12, 2026
33 of 35 checks passed
@ddogfoodd ddogfoodd deleted the update-harper branch January 12, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbsds pbsds Awaiting requested review from pbsds

2 more reviewers

@sumnerevans sumnerevans sumnerevans approved these changes

@MasterEvarior MasterEvarior MasterEvarior approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddogfoodd @MasterEvarior @sumnerevans @khaneliman