Skip to content

nixos/nextcloud: Use certificates bundle from path #481911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
provokateurin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nixos/nextcloud: Use certificates bundle from path #481911

provokateurin wants to merge 1 commit into from
+11 −20

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Jan 20, 2026

Reverts parts of #406252, as nextcloud/server#52749 has been merged and released on all supported versions. This avoids patching the package if custom certificates are used. The integration tests with custom certificates show that this works as expected.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@provokateurin provokateurin added the backport release-25.11 Backport PR automatically label Jan 20, 2026
@nixpkgs-ci nixpkgs-ci bot requested review from Ma27, bachp, britter and dotlambda January 20, 2026 10:38
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 20, 2026
@Ma27
Copy link
Member

Ma27 commented Jan 20, 2026

Review will follow later, just want to say that I highly appreciate that you followed through with improving the situation upstream as well! :)

@provokateurin
Copy link
Member Author

provokateurin commented Jan 20, 2026

No problem! The PR got a bit stale, but recently there was a customer who needed this, so I finally got the reviews I needed 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bachp bachp Awaiting requested review from bachp

@britter britter Awaiting requested review from britter

@dotlambda dotlambda Awaiting requested review from dotlambda

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. backport release-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@provokateurin @Ma27