Skip to content

python3Packages.polyfactory: disable failing test#482286

Closed
SkohTV wants to merge 1 commit into
NixOS:masterfrom
SkohTV:polyfactory-fix
Closed

python3Packages.polyfactory: disable failing test#482286
SkohTV wants to merge 1 commit into
NixOS:masterfrom
SkohTV:polyfactory-fix

Conversation

@SkohTV

@SkohTV SkohTV commented Jan 21, 2026

Copy link
Copy Markdown
Member

See tracking #475732

The tests are not failing on their CI (https://github.com/litestar-org/polyfactory/actions/runs/21131654878/job/60763959530), which is pretty weird
Also tried to change from v3.2.0 to the latest master commit, but still happening

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested a review from Bot-wxt1221 January 21, 2026 14:19
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Jan 21, 2026

disabledTestPaths = [
"tests/test_beanie_factory.py"
"tests/test_msgspec_factory.py"

@thunze thunze Jan 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test is failing on Python 3.14 because we're don't have msgspec 0.20.0 yet, which adds support for Python 3.14. I've seen similar test failures lately. Could you check if bumping msgspec like in #470239 helps?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does !
I'll remove it

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, actually it's the only change, so I'll close this instead

@SkohTV SkohTV closed this Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants