Skip to content

various: move netbox plugins to package set#515498

Open
felbinger wants to merge 15 commits intoNixOS:masterfrom
felbinger:netbox-plugins
Open

various: move netbox plugins to package set#515498
felbinger wants to merge 15 commits intoNixOS:masterfrom
felbinger:netbox-plugins

Conversation

@felbinger
Copy link
Copy Markdown
Member

@felbinger felbinger commented May 1, 2026

cc @minijackson @RaitoBezarius @Chaostheorie @xanderio @benley

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@felbinger
Copy link
Copy Markdown
Member Author

felbinger commented May 1, 2026

As suggested in #482364 I'm trying to move the netbox plugins to a package set.

I'm unsure if I added the plugins to netbox_4_5 properly. Feel free to advise me on how to do this.

If this is being merged before netbox_4_4 has been removed, the plugins also need to be copied to netbox_4_4 and downgraded to the appropriate versions (see netbox compability matrix of individual plugin).

@felbinger felbinger force-pushed the netbox-plugins branch 2 times, most recently from 622b629 to 159441f Compare May 1, 2026 14:57
@felbinger felbinger changed the title chore: move netbox plugins to package set various: move netbox plugins to package set May 1, 2026
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels May 1, 2026
@felbinger felbinger requested review from benley and xanderio May 1, 2026 15:34
@felbinger felbinger requested a review from Chaostheorie May 1, 2026 15:35
@felbinger
Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 515498
Commit: e584909ec37a2832c2955b8a98e56543ebcfffa6 (subsequent changes)
Merge: 96289993cc13889cb810e964844556f4ea10a82e

Logs: https://github.com/felbinger/nixpkgs-review-gha/actions/runs/25220585553


x86_64-linux

No rebuilds


aarch64-linux

No rebuilds


x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@felbinger felbinger marked this pull request as ready for review May 1, 2026 23:47
@nixpkgs-ci nixpkgs-ci Bot requested review from natsukium and transcaffeine May 1, 2026 23:53
Comment thread pkgs/by-name/ne/netbox_4_5/package.nix Outdated
Comment thread pkgs/top-level/all-packages.nix Outdated
Comment thread pkgs/top-level/python-packages.nix
Comment thread pkgs/by-name/ne/netbox_4_5/package.nix Outdated
@felbinger felbinger force-pushed the netbox-plugins branch 2 times, most recently from f507c7a to e5d53d0 Compare May 4, 2026 17:25
@felbinger felbinger force-pushed the netbox-plugins branch 5 times, most recently from 9ece264 to d6979ec Compare May 4, 2026 19:31
@felbinger
Copy link
Copy Markdown
Member Author

I think I finally got it. So should we copy the plugins to netbox_4_4, to use the correct versions for the current netbox version on nixpkgs-25.11 or do we ignore this, as it's being upgraded to netbox_4_5 in a few weeks anyway?
These packages got updated by this (#482364) bulk update, which was the reason why I opened this pr.

@minijackson
Copy link
Copy Markdown
Member

Thanks for doing this! I learned the existence of packagesFromDirectoryRecursive, very useful.

So should we copy the plugins to netbox_4_4, to use the correct versions for the current netbox version on nixpkgs-25.11 or do we ignore this, as it's being upgraded to netbox_4_5 in a few weeks anyway?

Nah, I don't think we need to do this.

The NetBox 4.4 package is marked as EOL, and the only reason we have multiple version of NetBox in nixpkgs is because I couldn't find a proper way to communicate to the user "be careful when doing this major NixOS upgrade, you might need to manually migrate some of your NetBox data". The current implementation requires the user to change the value of services.netbox.package to acknowledge that there's a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants