Skip to content

FIX: Prevent out-of-bounds write when initializing residuals in arima… #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vkverma9534 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

FIX: Prevent out-of-bounds write when initializing residuals in arima… #1073

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ef74d1
FIX: Prevent out-of-bounds write when initializing residuals in arima…
vkverma9534 Jan 5, 2026
8e2097a
FIX: Guard residual initialization against invalid ncond
vkverma9534 Jan 8, 2026
ab6ce1c
Merge branch 'main' into patch-1
nasaul Jan 8, 2026
fa816b8
applied the suggested fix
vkverma9534 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/arima.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <cmath>
#include <span>
#include <vector>
#include <stdexcept>

#include <pybind11/numpy.h>
#include <pybind11/pybind11.h>
Expand Down Expand Up @@ -136,7 +137,13 @@ arima_css(const py::array_t<double> yv, const py::array_t<int32_t> armav,

py::array_t<double> residv(n);
const auto resid = make_span(residv);
if (static_cast<size_t>(ncond) > resid.size()) {
throw std::logic_error(
"Internal error: resid length must be >= ncond"
);
}
std::fill_n(resid.begin(), ncond, 0.0);

std::vector<double> w(y.begin(), y.end());

for (size_t _ = 0; _ < d; ++_) {
Expand Down