Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update project standards #15

Merged
merged 11 commits into from
Dec 18, 2023
Merged

update project standards #15

merged 11 commits into from
Dec 18, 2023

Conversation

joelclermont
Copy link
Member

@joelclermont joelclermont commented Dec 15, 2023

This pulls in a bunch of changes we've made over the last year or so since we originally created this project standard.

The most notable changes:

  • Replace Docker node with Volta
  • Faster CI especially around Docker build times
  • Replace PHP_CodeSniffer with PHPCSFixer
  • Upgrade to PHP 10 and Laravel 10
  • Replace Bugsnag with Sentry
  • added strict model behavior for testing

This might be a good one to review commit by commit since all the coding standard tweaks are in a single commit.

I'm having second thoughts on using the Oracle mysql/mysql-server Docker images. They seem really stale (over a year old, and stuck on 8.0.32). Meanwhile, the Docker-provided mysql images are fully up to date, even has 8.2.0 pre-release stuff, and supports arm architecture now. Should we flip it back?

@joelclermont
Copy link
Member Author

@aaronsaray this is ready for review. I swapped out the Docker mysql image like we discussed

Copy link
Member

@aaronsaray aaronsaray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some notes

.phpunit.result.cache Outdated Show resolved Hide resolved
app/Models/Permission.php Outdated Show resolved Hide resolved
phpunit.xml Show resolved Hide resolved
phpunit.xml Show resolved Hide resolved
tests/Feature/ExampleTest.php Outdated Show resolved Hide resolved
tests/Unit/ExampleTest.php Show resolved Hide resolved
Copy link
Member

@aaronsaray aaronsaray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@aaronsaray aaronsaray merged commit 988495c into main Dec 18, 2023
1 check passed
@aaronsaray aaronsaray deleted the standards-updates branch December 18, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants