merge in updates from recent projects and move to OrbStack #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronsaray
requested changes
Jun 12, 2024
README_TEMPLATE.md
Outdated
| @@ -56,22 +59,23 @@ Once `mkcert` is installed, we need to generate our local development root certi | |||
|
|
|||
| Then, generate the certificates for this project and put them into a location accessible to your docker setup: | |||
|
|
|||
| `mkcert -cert-file docker/nginx/ssl.pem -key-file docker/nginx/key.pem my-project.test` | |||
| `mkcert -cert-file docker/nginx/ssl.pem -key-file docker/nginx/key.pem my-project.local` | |||
There was a problem hiding this comment.
Should these be in docker/nginx anymore? Because they're for Vite.
There was a problem hiding this comment.
Actually looks like you've got a .gitignore for vite dir further down - so this is probably just the wrong path here.
docker-compose.yml
Outdated
| volumes: | ||
| - mysql-data:/var/lib/mysql | ||
| # Uncomment the next line if you need scripts to run on mysql initialization, like creating multiple databases |
There was a problem hiding this comment.
Why not just leave it uncommented? Shouldn't hurt anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.