Skip to content

Mod Versionlist Overflow & Improved Logging#213

Open
SirKnubble wants to merge 12 commits intoNoRiskClient:dev/0.6.20from
SirKnubble:dev/0.6.20
Open

Mod Versionlist Overflow & Improved Logging#213
SirKnubble wants to merge 12 commits intoNoRiskClient:dev/0.6.20from
SirKnubble:dev/0.6.20

Conversation

@SirKnubble
Copy link
Copy Markdown
Contributor

@SirKnubble SirKnubble commented Feb 10, 2026

@SirKnubble
Copy link
Copy Markdown
Contributor Author

SirKnubble commented Feb 10, 2026

Debug Logs Console Only, Base for future PR, removing unnecessary Info Log Level (below)
image

@SirKnubble SirKnubble changed the title Launcher Issues 2026 (v1) Mod Versionlist Overflow & Improved Logging Feb 16, 2026
@SirKnubble
Copy link
Copy Markdown
Contributor Author

🤤
image

@SirKnubble
Copy link
Copy Markdown
Contributor Author

old
image
new
image

@SirKnubble
Copy link
Copy Markdown
Contributor Author

SirKnubble commented Feb 17, 2026

Debug Logs in RAM, gespeichert in debug-logfile bei Event Log "Error" oder Hotkey Ctrl/Cmd + Shift + D.

Meine Empfehlung: Alles unnötige für die normalen Logs zu Debug, alles was in den normalen Logs reicht um Fehlerquelle zu finden wie passed/failed checkpoints in Info/Warn, alles wo ihr wollt dass er autosaved zu Error.
(oder das capture level anpassen)

image image

@SirKnubble
Copy link
Copy Markdown
Contributor Author

Bin Raus!
Bis in Paar Monaten, schreibt wenn dringend vielleicht find ich Zeit.
image
@copyandexecute

@SirKnubble SirKnubble marked this pull request as ready for review February 20, 2026 23:30
@brentspine
Copy link
Copy Markdown
Member

Same, die Arbeit ruft wieder 😭

@brentspine
Copy link
Copy Markdown
Member

Macher, dass du das noch gemacht hast

@SirKnubble
Copy link
Copy Markdown
Contributor Author

SirKnubble commented Feb 23, 2026

Macher, dass du das noch gemacht hast

Mit Herz aber wenn ich die PRs sehe, seit 5m offen mit Kommentar "im looking into it" hab ich keine große hoffnung 💔

@brentspine
Copy link
Copy Markdown
Member

Ja, finde ich auch schade… Sehr schade sogar

@brentspine
Copy link
Copy Markdown
Member

@copyandexecute Entweder kümmerst du dich drum, oder vertraust merging auch Robin, Enrico, Tim und Kavatch an

@SirKnubble
Copy link
Copy Markdown
Contributor Author

@copyandexecute

@SirKnubble
Copy link
Copy Markdown
Contributor Author

@copyandexecute
image-8.png

@SirKnubble
Copy link
Copy Markdown
Contributor Author

@copyandexecute

1 similar comment
@SirKnubble
Copy link
Copy Markdown
Contributor Author

@copyandexecute

@SirKnubble
Copy link
Copy Markdown
Contributor Author

SirKnubble commented Mar 9, 2026

@SirKnubble
Copy link
Copy Markdown
Contributor Author

@copyandexecute
Copy link
Copy Markdown
Contributor

@copyandexecute has anyone tested these changes are they working? @Deadmake could you please check if everything is alright

@copyandexecute
Copy link
Copy Markdown
Contributor

is memory really broken right now? why did you change everything to debug

@copyandexecute
Copy link
Copy Markdown
Contributor

thanks for your effort, could you please put the "4 memory" leaks in a separate PR rather than everything in a big one
because there are changes I don't want to merge yet or even at all? please provide more context, I like you khubble <3

@SirKnubble
Copy link
Copy Markdown
Contributor Author

@copyandexecute has anyone tested these changes are they working? @Deadmake could you please check if everything is alright

?
@BigBrainRobin29 can test he faster

is memory really broken right now? why did you change everything to debug

i mean only if there are prs i cant see to fix all the issues related to memory overflows, others all documented in pr, mainly cuz NoRiskClient/issues#2572

could you please put the "4 memory" leaks in a separate PR rather than everything in a big one

you "trolling". but will be done in no time

@SirKnubble
Copy link
Copy Markdown
Contributor Author

1 change excluded from revert which is NECESSARY. (src-tauri/src/logging.rs)

@SirKnubble
Copy link
Copy Markdown
Contributor Author

@copyandexecute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants