Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Add proxy support #11

Open
NoahCardoza opened this issue Jul 20, 2020 · 16 comments
Open

TODO: Add proxy support #11

NoahCardoza opened this issue Jul 20, 2020 · 16 comments
Assignees
Labels
enhancement New feature or request todo Things that I want to work on in the near future.

Comments

@NoahCardoza
Copy link
Owner

NoahCardoza commented Jul 20, 2020

Proxy Support

Add a proxy parameter that will launch a browser instance and proxy traffic through the server passed in the params.

Notes:

@NoahCardoza NoahCardoza added enhancement New feature or request todo Things that I want to work on in the near future. labels Jul 20, 2020
@khorezm0
Copy link
Contributor

great, i had to do it by myself)

@NoahCardoza
Copy link
Owner Author

If you’ve already made the necessary changes, feel free to open a PR. I’ll be out of town for a couple days but I’ll merge it when I get back.

Sent with GitHawk

@NoahCardoza
Copy link
Owner Author

@khorezm0 Do you think you could make a PR request with your changes?

@khorezm0
Copy link
Contributor

My changes are quite simple so yes i can, i m gonna do it but im not home rn, so i'll do it tomorrow

@NoahCardoza
Copy link
Owner Author

Great! Thanks for the help!

@NoahCardoza
Copy link
Owner Author

I'll close this as soon as I update the documentation.

@NoahCardoza
Copy link
Owner Author

@khorezm0 Actually, I just noticed some changes I think I'll make to cache the proxy authentication when you initiate the instance with sessions.create since it doesn't make sense to keep passing the auth to every request, unless there is a reason you did it that way?

@NoahCardoza NoahCardoza pinned this issue Aug 1, 2020
@khorezm0
Copy link
Contributor

khorezm0 commented Aug 1, 2020

@khorezm0 Actually, I just noticed some changes I think I'll make to cache the proxy authentication when you initiate the instance with sessions.create since it doesn't make sense to keep passing the auth to every request, unless there is a reason you did it that way?

No, there is no reasons to it, just didn't thought about it.

@NoahCardoza
Copy link
Owner Author

Alright, good to know. I'll try to fix this up by the end of the week.

@NoahCardoza NoahCardoza self-assigned this Aug 3, 2020
@NoahCardoza
Copy link
Owner Author

Been lagging on this for a while, this is a reminder for me to look into this SOON!

@khorezm0
Copy link
Contributor

khorezm0 commented Sep 2, 2020

:)

@phongtnit
Copy link

phongtnit commented Dec 9, 2020

Does the latest version of CloudProxy support proxy? I added proxy = { "url": "ip:port", "username": "user", "password": "pass" } to CloudProxy request.get but it don't work. I tested with https://whatismyipaddress.com/ website.

@khorezm0
Copy link
Contributor

khorezm0 commented Dec 9, 2020

Should be not. Once it will, this issue should be closed.

@serk7
Copy link
Contributor

serk7 commented Dec 16, 2021

Does the latest version of CloudProxy support proxy? I added proxy = { "url": "ip:port", "username": "user", "password": "pass" } to CloudProxy request.get but it don't work. I tested with https://whatismyipaddress.com/ website.

Yes it supports proxy, but it should be a proxy without AUTH. Because chrome don't accept user:password on the command line. You should set your proxy to be restricted to your ip.

@thanh109
Copy link

thanh109 commented May 9, 2023

how to use proxy in CloudProxy ? Help me

@khorezm0
Copy link
Contributor

how to use proxy in CloudProxy ? Help me

It would be more helpful if you told us what you have tried to get it working.

Have you tried this? #13 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request todo Things that I want to work on in the near future.
Projects
None yet
Development

No branches or pull requests

5 participants