Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push proxy update #13

Merged
merged 1 commit into from
Jul 31, 2020
Merged

push proxy update #13

merged 1 commit into from
Jul 31, 2020

Conversation

khorezm0
Copy link
Contributor

@khorezm0 khorezm0 commented Jul 28, 2020

Simple plan:

  1. Specify proxy in session, so we launch a borwser with proxy args
  2. Login into proxy when pages load (cant find another way to enter credentials)
    Issued in TODO: Add proxy support #11

Copy link
Owner

@NoahCardoza NoahCardoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry for the on the merge!

@NoahCardoza NoahCardoza merged commit e930fc4 into NoahCardoza:master Jul 31, 2020
@NoahCardoza
Copy link
Owner

Actually, could you give an example of the proxy object that would be passed to the server?

I'm assuming it would be like:

{
  "url": "proxy.host",
  "username": "optional",
  "password": "only_with_username"
}

I'm assuming you wouldn't use a URL likeoptional:[email protected] since the username/password is passed in their own fields but I just want to make sure before I update the README.

Thanks for the help!

@khorezm0
Copy link
Contributor Author

Actually, could you give an example of the proxy object that would be passed to the server?

I'm assuming it would be like:

{
  "url": "proxy.host",
  "username": "optional",
  "password": "only_with_username"
}

I'm assuming you wouldn't use a URL likeoptional:[email protected] since the username/password is passed in their own fields but I just want to make sure before I update the README.

Thanks for the help!

Authorization to proxy on chrome is little bit tricky) So yes, there is an object with exactly thats fields in it. I suppose it can be modified so it look cleanier, it was just a hotfix feature i did for myself)

@NoahCardoza NoahCardoza mentioned this pull request Aug 6, 2020
@torstendeppe
Copy link

Hey,

can you please update the documentation?

How can I use this feature?

Or should i only do something like

{ "cmd":"request.get", "url":"https://example.com", "userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.0 Safari/537.36", "maxTimeout":60000, "proxy": "??" }

Thanks

@NoahCardoza
Copy link
Owner

I'm pretty sure there is a reason I didn't add it to the docs bc something didn't work right, but you could try passing it like this:

{
  "proxy": {
    "host: "127.0.0.1",
    "port": 1337
  }
}

I'll have to properly look into this issue soon, but I've been busy lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants