Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicely format logged warnings #223

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Nicely format logged warnings #223

merged 4 commits into from
Aug 3, 2023

Conversation

bittremieux
Copy link
Collaborator

Fixes #222.

@bittremieux bittremieux linked an issue Jul 31, 2023 that may be closed by this pull request
Make the Pytorch Lightning messages go through our logger #222
Closed
@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #223 (70bcee1) into dev (ad48a09) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #223      +/-   ##
==========================================
+ Coverage   88.87%   88.92%   +0.04%     
==========================================
  Files          12       12              
  Lines         899      903       +4     
==========================================
+ Hits          799      803       +4     
  Misses        100      100
Files Changed Coverage Δ
casanovo/casanovo.py 74.26% <100.00%> (+0.61%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

VarunAnanth2003
VarunAnanth2003 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@VarunAnanth2003 VarunAnanth2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at changed files, nothing added should break anything.

@bittremieux bittremieux merged commit e1e1bb0 into dev Aug 3, 2023
5 checks passed
@bittremieux bittremieux deleted the log_warnings branch August 3, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VarunAnanth2003 VarunAnanth2003 VarunAnanth2003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the Pytorch Lightning messages go through our logger
2 participants
@bittremieux @VarunAnanth2003