Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation and checkpointing interval #224

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Fix validation and checkpointing interval #224

merged 4 commits into from
Aug 3, 2023

Conversation

bittremieux
Copy link
Collaborator

The option to configure the interval for validation and checkpointing has been changed:

  • Config option every_n_train_steps has been renamed to val_check_interval in accordance to the corresponding Pytorch Lightning parameter.
  • This now determines the number of training steps across epochs instead of within a single epoch. I.e. previously if there were 75,000 batches in the training data, validation would run at epoch=0,steps=50k; epoch=1,steps=50k; epoch=2,steps=50k; ...; whereas now it will run at epoch=0,steps=50k; epoch=1,steps=25k; epoch=1,steps=75k; ...

Fixes #211.

@bittremieux bittremieux linked an issue Jul 31, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #224 (04fc7de) into dev (ad48a09) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #224   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files          12       12           
  Lines         899      899           
=======================================
  Hits          799      799           
  Misses        100      100           
Files Changed Coverage Δ
casanovo/config.py 87.80% <ø> (ø)
casanovo/denovo/model_runner.py 87.59% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@VarunAnanth2003 VarunAnanth2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeCov coverage did not change and all tests passed. Looked at code and no changes will break anything. Good to go

@bittremieux bittremieux merged commit 3ac0887 into dev Aug 3, 2023
5 checks passed
@bittremieux bittremieux deleted the val_interval branch August 3, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problematic check_val_every_n_epoch message
2 participants