Added shuffling to trainset dataloaders, no shuffle by default for ot… #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #234 +/- ##
==========================================
+ Coverage 89.13% 89.24% +0.11%
==========================================
Files 12 12
Lines 902 902
==========================================
+ Hits 804 805 +1
+ Misses 98 97 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default casanovo does not shuffle the dataloaders' batches. This quick patch simply adds an arg in dataloaders.py, within the
DeNovoDataModuleclass, and within the_make_loader()method that determines shuffling. This param is set to false by default and set to true only when_make_loader()is called within thetrain_dataloader()method.